From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7727329D19 for ; Fri, 2 Aug 2024 07:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722583202; cv=none; b=CyL/JHtsEYlNkVx5ZKPNtXOalfzNRTA8SCRwU30TB1zms05JI+YZElp2zgQw/G4JRex0fYolt2aIWwsdwu5yTuy7McLtHZkeSMjMINHzwEJ1LSnHjTcKUJHE/BihMrcsPFmJwaJD88iwl8cqaPwPyFnxk1u+6256YQKNBZgWURk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722583202; c=relaxed/simple; bh=tpQDC4ZfJ/+0w7kXmr/5VcUxRYrr9BiImQsi3DLoPZk=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bZmP0AWX101U5mJw3kETXEIj00Gls3yRVCbm+GaOVvlpsTH9xEUT6rHriouVz0aT8AUVEIXgPt6o1Jt1Q0c5MX8NYyEVyMBHAa53k4WueUC33ZAZ/tRSzc4/nKNmYXgAzuxO35Sx7l21b0Bote35Qec/A8sUIN35Wace2lR5YEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=B5OyiGo8; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=UoMh7W8a; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=B5OyiGo8; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=UoMh7W8a; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="B5OyiGo8"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="UoMh7W8a"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="B5OyiGo8"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="UoMh7W8a" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A2BD31FB98; Fri, 2 Aug 2024 07:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722583198; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JJy0NEHga6HO6ajFj1YHnPCF6nMNpmhG3jW8yyYVdp8=; b=B5OyiGo8DplaS4CBtlAyNJIPHyX6hl/2P9zSKnWd+bpvpoLDVN91eah2p/2m778Kqf+VcB dCGW8Vhc+oxbpbqu6OKPh2AWLCfYFwwOOgoVfGHWpHrqTESNJmNjmchcj7HA7GIVJ5RjCN uOWXMoIpQWAA85/1nCRm4HKBfkE/Hy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722583198; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JJy0NEHga6HO6ajFj1YHnPCF6nMNpmhG3jW8yyYVdp8=; b=UoMh7W8aE23OdvrTarkafwyKFWtUe2YSOuEdFNxYgD0K3Y1erwW3x5ucNMyrPEgE16Alpq uMxOUcrLc018lABg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722583198; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JJy0NEHga6HO6ajFj1YHnPCF6nMNpmhG3jW8yyYVdp8=; b=B5OyiGo8DplaS4CBtlAyNJIPHyX6hl/2P9zSKnWd+bpvpoLDVN91eah2p/2m778Kqf+VcB dCGW8Vhc+oxbpbqu6OKPh2AWLCfYFwwOOgoVfGHWpHrqTESNJmNjmchcj7HA7GIVJ5RjCN uOWXMoIpQWAA85/1nCRm4HKBfkE/Hy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722583198; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JJy0NEHga6HO6ajFj1YHnPCF6nMNpmhG3jW8yyYVdp8=; b=UoMh7W8aE23OdvrTarkafwyKFWtUe2YSOuEdFNxYgD0K3Y1erwW3x5ucNMyrPEgE16Alpq uMxOUcrLc018lABg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 663D513AED; Fri, 2 Aug 2024 07:19:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZKjdF56IrGYgBAAAD6G6ig (envelope-from ); Fri, 02 Aug 2024 07:19:58 +0000 Date: Fri, 2 Aug 2024 09:19:59 +0200 From: Petr Vorel To: Aleksa Sarai , Andrea Cervesato , ltp@lists.linux.it, Alexey Gladkov , Christian Brauner , Cyril Hrubis , Adhemerval Zanella , =?iso-8859-2?Q?Ga=EBl?= PORTAY , linux-kernel@vger.kernel.org Subject: Re: [LTP] [PATCH v4 0/5] Add fchmodat2 testing suite Message-ID: <20240802071959.GA1593427@pevik> Reply-To: Petr Vorel References: <20240801-fchmodat2-v4-0-7f2f11a53a09@suse.com> <20240801165756.GA1526142@pevik> <20240802.011554-broke.flocks.valiant.camp-sk9TjsxvPYf@cyphar.com> <20240802054252.GA1582980@pevik> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802054252.GA1582980@pevik> X-Spam-Level: X-Spamd-Result: default: False [-0.30 / 50.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[] X-Spam-Flag: NO X-Spam-Score: -0.30 Hi all, ... > @Andrea, I guess we want something like this: > +++ testcases/kernel/syscalls/fchmodat2/fchmodat2_01.c > @@ -43,9 +43,10 @@ static void test_symbolic_link(void) > verify_mode(fd_dir, FNAME, S_IFREG | 0700); > verify_mode(fd_dir, SNAME, S_IFLNK | 0777); > - TST_EXP_PASS(fchmodat2(fd_dir, SNAME, 0640, AT_SYMLINK_NOFOLLOW)); > - verify_mode(fd_dir, FNAME, S_IFREG | 0700); > - verify_mode(fd_dir, SNAME, S_IFLNK | 0640); > + if (tst_kvercmp(6, 6, 0) >= 0) { > + TST_EXP_FAIL(tst_syscall(__NR_fchmodat2, fd_dir, SNAME, 0640, > + AT_SYMLINK_NOFOLLOW), EOPNOTSUPP); > + } > } Actually, this has been backported to all stable/LTS trees (up to 4.19). Thus there should not be a version check, but instead suggesting a missing 5d1f903f75a8 commit. .tags = (const struct tst_tag[]) { {"linux-git", "5d1f903f75a8"}, {} } Kind regards, Petr