From: kan.liang@linux.intel.com
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, irogers@google.com,
linux-kernel@vger.kernel.org
Cc: Kan Liang <kan.liang@linux.intel.com>
Subject: [PATCH 0/7] Generic hotplug support for a PMU with a scope
Date: Fri, 2 Aug 2024 08:16:36 -0700 [thread overview]
Message-ID: <20240802151643.1691631-1-kan.liang@linux.intel.com> (raw)
From: Kan Liang <kan.liang@linux.intel.com>
The perf subsystem assumes that the counters of a PMU are per-CPU. So
the user space tool reads a counter from each CPU in the system wide
mode. However, many PMUs don't have a per-CPU counter. The counter is
effective for a scope, e.g., a die or a socket. To address this, a
cpumask is exposed by the kernel driver to restrict to one CPU to stand
for a specific scope. In case the given CPU is removed,
the hotplug support has to be implemented for each such driver.
The codes to support the cpumask and hotplug are very similar.
- Expose a cpumask into sysfs
- Pickup another CPU in the same scope if the given CPU is removed.
- Invoke the perf_pmu_migrate_context() to migrate to a new CPU.
- In event init, always set the CPU in the cpumask to event->cpu
- Usually, an event can be read from any CPU of the scope. (For now,
it is only supported by the pkg scope PMU, via
PERF_EV_CAP_READ_ACTIVE_PKG, e.g., cstate_pkg, rapl, etc)
Similar duplicated codes are implemented for each such PMU driver. It
would be good to introduce a generic infrastructure to avoid such
duplication.
The patch series introduce 5 popular scopes, core, die, cluster, pkg,
and the system-wide. The PMU drivers for cstate, iommu, idxd and rapl
are updated to apply the new infrastructure. The new infrastructure
can also be applied for other PMU drivers from different ARCHs as well.
But I don't have such platforms. It's not done in this patch series.
They can be added later separately.
The uncore driver isn't updated either. Because a per-PMU cpumask is
required since commit c74443d92f68 ("perf/x86/uncore: Support per PMU
cpumask"). Since different types of PMU share the same hotplug codes,
more factor out works and verification are expected. The cleanup of the
uncore driver can be done later separately.
Kan Liang (7):
perf: Generic hotplug support for a PMU with a scope
perf: Add PERF_EV_CAP_READ_SCOPE
perf/x86/intel/cstate: Clean up cpumask and hotplug
iommu/vt-d: Clean up cpumask and hotplug
dmaengine: idxd: Clean up cpumask and hotplug
perf/x86/rapl: Move the pmu allocation out of CPU hotplug
perf/x86/rapl: Clean up cpumask and hotplug
arch/x86/events/intel/cstate.c | 140 +-------------------------
arch/x86/events/rapl.c | 119 ++++++----------------
drivers/dma/idxd/idxd.h | 7 --
drivers/dma/idxd/init.c | 3 -
drivers/dma/idxd/perfmon.c | 98 +-----------------
drivers/iommu/intel/iommu.h | 2 -
drivers/iommu/intel/perfmon.c | 111 +--------------------
include/linux/cpuhotplug.h | 3 -
include/linux/perf_event.h | 21 ++++
kernel/events/core.c | 176 ++++++++++++++++++++++++++++++++-
10 files changed, 229 insertions(+), 451 deletions(-)
--
2.38.1
next reply other threads:[~2024-08-02 15:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 15:16 kan.liang [this message]
2024-08-02 15:16 ` [PATCH 1/7] perf: Generic hotplug support for a PMU with a scope kan.liang
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-09-12 10:12 ` Steven Price
2024-09-12 14:53 ` Liang, Kan
2024-09-19 15:43 ` [PATCH 1/7] " Guenter Roeck
2024-09-19 16:28 ` Liang, Kan
2024-10-23 17:09 ` Matthieu Baerts
2024-10-23 17:46 ` Liang, Kan
2024-10-23 18:19 ` Peter Zijlstra
2024-08-02 15:16 ` [PATCH 2/7] perf: Add PERF_EV_CAP_READ_SCOPE kan.liang
2024-09-06 15:11 ` Peter Zijlstra
2024-09-06 15:26 ` Liang, Kan
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-08-02 15:16 ` [PATCH 3/7] perf/x86/intel/cstate: Clean up cpumask and hotplug kan.liang
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-08-02 15:16 ` [PATCH 4/7] iommu/vt-d: Clean up cpumask and hotplug for perfmon kan.liang
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-08-02 15:16 ` [PATCH 5/7] dmaengine: idxd: " kan.liang
2024-08-05 15:40 ` Dave Jiang
2024-08-05 17:46 ` Fenghua Yu
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-08-02 15:16 ` [PATCH 6/7] perf/x86/rapl: Move the pmu allocation out of CPU hotplug kan.liang
2024-09-09 9:26 ` Dhananjay Ugwekar
2024-09-09 13:02 ` Liang, Kan
2024-09-09 13:24 ` Peter Zijlstra
2024-09-09 17:11 ` Liang, Kan
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-08-02 15:16 ` [PATCH 7/7] perf/x86/rapl: Clean up cpumask and hotplug kan.liang
2024-09-10 9:59 ` [tip: perf/core] " tip-bot2 for Kan Liang
2024-09-04 12:44 ` [PATCH 0/7] Generic hotplug support for a PMU with a scope Liang, Kan
2024-09-06 15:17 ` Peter Zijlstra
2024-09-06 15:30 ` Liang, Kan
2024-09-06 15:12 ` Peter Zijlstra
2024-09-06 15:30 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802151643.1691631-1-kan.liang@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox