public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jordan Crouse <jorcrous@amazon.com>
To: <linux-media@vger.kernel.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v1 0/2] media: camss: Fixups for large capture frames
Date: Fri, 2 Aug 2024 15:24:32 +0000	[thread overview]
Message-ID: <20240802152435.35796-1-jorcrous@amazon.com> (raw)

A few small issues discovered while (thus far unsuccessfully) trying to bring
up a 64MP sensor. The chosen frame limitation of 8192 seems to be somewhat
arbitrary as there don't appear to be any hardware limits on maximum frame size.
Double the maximum allowable frame size to accommodate bigger sensors.

Next the larger data sizes end up needing bigger pixel clocks. This exposed a
bug for 8250 devices where the VFE clocks are shared between two blocks, but
the CSID block is being initialized second and overwriting the carefully
selected clock rates from VFE. This was likely not a problem earlier because
the lowest VFE clock rate that CSID was selecting was good enough for the
family of sensors that were being used.


Jordan Crouse (2):
  media: camss: Increase the maximum frame size
  media: camss: Avoid overwriting vfe clock rates for 8250

 .../media/platform/qcom/camss/camss-csid.c    |  8 +++----
 .../media/platform/qcom/camss/camss-csiphy.c  |  4 ++--
 .../media/platform/qcom/camss/camss-ispif.c   |  4 ++--
 drivers/media/platform/qcom/camss/camss-vfe.c |  4 ++--
 .../media/platform/qcom/camss/camss-video.c   |  6 +++---
 drivers/media/platform/qcom/camss/camss.c     | 21 +++++++++++++------
 6 files changed, 28 insertions(+), 19 deletions(-)

-- 
2.40.1


             reply	other threads:[~2024-08-02 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 15:24 Jordan Crouse [this message]
2024-08-02 15:24 ` [PATCH v1 1/2] media: camss: Increase the maximum frame size Jordan Crouse
2024-08-06 23:09   ` Bryan O'Donoghue
2024-08-07  8:16     ` Bryan O'Donoghue
2024-12-06 14:51   ` Luca Weiss
2025-04-07 15:59     ` Bryan O'Donoghue
2024-08-02 15:24 ` [PATCH v1 2/2] media: camss: Avoid overwriting vfe clock rates for 8250 Jordan Crouse
2024-08-02 22:20   ` Bryan O'Donoghue
2024-08-06 22:38     ` Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240802152435.35796-1-jorcrous@amazon.com \
    --to=jorcrous@amazon.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox