From: Jonathan Cameron <jic23@kernel.org>
To: Mariel Tinaco <Mariel.Tinaco@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
"Dimitri Fedrau" <dima.fedrau@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <noname.nuno@gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: add docs for ad8460
Date: Sat, 3 Aug 2024 11:05:45 +0100 [thread overview]
Message-ID: <20240803110545.61885486@jic23-huawei> (raw)
In-Reply-To: <20240730030509.57834-2-Mariel.Tinaco@analog.com>
On Tue, 30 Jul 2024 11:05:08 +0800
Mariel Tinaco <Mariel.Tinaco@analog.com> wrote:
> This adds the bindings documentation for the 14-bit
> High Voltage, High Current, Waveform Generator
> Digital-to-Analog converter.
>
A few additions to Krzysztof's much more detailed review.
Wrap patch descriptions to 75 chars. not sub 55.
> Signed-off-by: Mariel Tinaco <Mariel.Tinaco@analog.com>
> +
> + adi,rset-ohms:
Please rename this as rset sounds like reset to me. Not sure what a
good name is however!
> + description: Specify value of external resistor connected to FS_ADJ pin
> + to establish internal HVDAC's reference current I_REF
> + default: 2000
> + minimum: 2000
> + maximum: 20000
> +
next prev parent reply other threads:[~2024-08-03 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 3:05 [PATCH v2 0/2] add AD8460 DAC driver Mariel Tinaco
2024-07-30 3:05 ` [PATCH v2 1/2] dt-bindings: iio: dac: add docs for ad8460 Mariel Tinaco
2024-07-30 6:15 ` Krzysztof Kozlowski
2024-08-17 11:18 ` Tinaco, Mariel
2024-08-18 7:04 ` Krzysztof Kozlowski
2024-08-03 10:05 ` Jonathan Cameron [this message]
2024-08-17 11:19 ` Tinaco, Mariel
2024-07-30 3:05 ` [PATCH v2 2/2] iio: dac: support the ad8460 Waveform DAC Mariel Tinaco
2024-08-02 6:21 ` kernel test robot
2024-08-02 8:04 ` kernel test robot
2024-08-02 9:46 ` kernel test robot
2024-08-03 10:29 ` Jonathan Cameron
2024-08-17 11:59 ` Tinaco, Mariel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240803110545.61885486@jic23-huawei \
--to=jic23@kernel.org \
--cc=Mariel.Tinaco@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=noname.nuno@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox