linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: build failure caused by RUNTIME_CONST()
Date: Sat, 3 Aug 2024 14:01:37 +0200	[thread overview]
Message-ID: <20240803120136.GA2986@redhat.com> (raw)
In-Reply-To: <CAHk-=wiXK4cc8ikqN15vfi2+wsYJYh08qH8qzCpy+08Gh9whLw@mail.gmail.com>

On 08/02, Linus Torvalds wrote:
>
> On Fri, 2 Aug 2024 at 15:10, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> >         $ ld -v
> >         GNU ld version 2.25-17.fc23
>
> Yeah, we document that we support building with ld-2.25.

Where? I tried to grep Documentation/ but didn't find anything...

> Reported-by: Oleg Nesterov <oleg@redhat.com>
> Link: https://sourceware.org/binutils/docs/ld/Input-Section-Example.html [1]
> Link: https://lore.kernel.org/all/20240802114518.GA20924@redhat.com/
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Tested-by: Oleg Nesterov <oleg@redhat.com>

But,

> -#define RUNTIME_NAME(t,x) runtime_##t##_##x
> +#define NAMED_SECTION(name) \
> +	name : AT(ADDR(name) - LOAD_OFFSET) ALIGN(8) \
                                            ^^^^^^^^
it seems that all other section do

	. = ALIGN(x); name : ...

was this change intentional?

Oleg.


  reply	other threads:[~2024-08-03 12:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 11:45 build failure caused by RUNTIME_CONST() Oleg Nesterov
2024-08-02 16:50 ` Linus Torvalds
2024-08-02 22:10   ` Oleg Nesterov
2024-08-03  1:19     ` Linus Torvalds
2024-08-03 12:01       ` Oleg Nesterov [this message]
2024-08-03 15:35         ` Linus Torvalds
2024-08-03 15:45         ` Linus Torvalds
2024-08-05  7:19       ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240803120136.GA2986@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).