Re: [PATCH 4/6] sched_ext: Simplify UP support by enabling sched_class->balance() in UP

David Vernet
2024-08-05T19:49:17Z

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Sat, Aug 03, 2024 at 04:40:11PM -1000, Tejun Heo wrote:
> On SMP, SCX performs dispatch from sched_class->balance(). As balance() was
> not available in UP, it instead called the internal balance function from
> put_prev_task_scx() and pick_next_task_scx() to emulate the effect, which is
> rather nasty.
>
> Enabling sched_class->balance() on UP shouldn't cause any meaningful
> overhead. Enable balance() on UP and drop the ugly workaround.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>

Acked-by: David Vernet <void@manifault.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]