From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v3 4/7] iommu/vt-d: Prepare for global static identity domain
Date: Tue, 6 Aug 2024 10:39:38 +0800 [thread overview]
Message-ID: <20240806023941.93454-5-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20240806023941.93454-1-baolu.lu@linux.intel.com>
With the static identity domain in place, the domain field of per-device
iommu driver data can be either a pointer to a DMA translation domain, or
NULL, indicating that the static identity domain is attached. Refactor
the code to prepare for this change.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/iommu.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index c019fb3b3e78..f37c8c3cba3c 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -1270,6 +1270,9 @@ void domain_update_iotlb(struct dmar_domain *domain)
bool has_iotlb_device = false;
unsigned long flags;
+ if (!domain)
+ return;
+
spin_lock_irqsave(&domain->lock, flags);
list_for_each_entry(info, &domain->devices, link) {
if (info->ats_enabled) {
@@ -3706,11 +3709,9 @@ int prepare_domain_attach_device(struct iommu_domain *domain,
static int intel_iommu_attach_device(struct iommu_domain *domain,
struct device *dev)
{
- struct device_domain_info *info = dev_iommu_priv_get(dev);
int ret;
- if (info->domain)
- device_block_translation(dev);
+ device_block_translation(dev);
ret = prepare_domain_attach_device(domain, dev);
if (ret)
@@ -4321,6 +4322,11 @@ static void intel_iommu_remove_dev_pasid(struct device *dev, ioasid_t pasid,
struct intel_iommu *iommu = info->iommu;
unsigned long flags;
+ if (domain->type == IOMMU_DOMAIN_IDENTITY) {
+ intel_pasid_tear_down_entry(iommu, dev, pasid, false);
+ return;
+ }
+
spin_lock_irqsave(&dmar_domain->lock, flags);
list_for_each_entry(curr, &dmar_domain->dev_pasids, link_domain) {
if (curr->dev == dev && curr->pasid == pasid) {
--
2.34.1
next prev parent reply other threads:[~2024-08-06 2:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 2:39 [PATCH v3 0/7] iommu/vt-d: Convert to use static identity domain Lu Baolu
2024-08-06 2:39 ` [PATCH v3 1/7] iommu/vt-d: Require DMA domain if hardware not support passthrough Lu Baolu
2024-08-06 16:54 ` Jason Gunthorpe
2024-08-14 16:13 ` Jerry Snitselaar
2024-08-06 2:39 ` [PATCH v3 2/7] iommu/vt-d: Remove identity mappings from si_domain Lu Baolu
2024-08-06 17:05 ` Jason Gunthorpe
2024-08-07 6:14 ` Baolu Lu
2024-08-06 2:39 ` [PATCH v3 3/7] iommu/vt-d: Always reserve a domain ID for identity setup Lu Baolu
2024-08-06 17:06 ` Jason Gunthorpe
2024-08-07 6:19 ` Baolu Lu
2024-08-07 12:09 ` Jason Gunthorpe
2024-08-07 13:38 ` Baolu Lu
2024-08-14 16:31 ` Jerry Snitselaar
2024-08-06 2:39 ` Lu Baolu [this message]
2024-08-06 17:12 ` [PATCH v3 4/7] iommu/vt-d: Prepare for global static identity domain Jason Gunthorpe
2024-08-07 6:41 ` Baolu Lu
2024-08-07 12:17 ` Jason Gunthorpe
2024-08-07 13:44 ` Baolu Lu
2024-08-06 2:39 ` [PATCH v3 5/7] iommu/vt-d: Factor out helpers from domain_context_mapping_one() Lu Baolu
2024-08-06 17:13 ` Jason Gunthorpe
2024-08-14 16:19 ` Jerry Snitselaar
2024-08-06 2:39 ` [PATCH v3 6/7] iommu/vt-d: Add support for static identity domain Lu Baolu
2024-08-06 17:18 ` Jason Gunthorpe
2024-08-06 2:39 ` [PATCH v3 7/7] iommu/vt-d: Cleanup si_domain Lu Baolu
2024-08-06 17:19 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806023941.93454-5-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox