public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Vitor Massaru Iha <vitor@massaru.org>,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, brendanhiggins@google.com,
	davidgow@google.com, skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3] lib: Convert test_user_copy to KUnit test
Date: Tue, 6 Aug 2024 12:34:23 -0700	[thread overview]
Message-ID: <202408061232.B6382B6DA0@keescook> (raw)
In-Reply-To: <a41ab091-42d3-4e03-b0e8-89af354faadc@roeck-us.net>

On Tue, Aug 06, 2024 at 08:48:43AM -0700, Guenter Roeck wrote:
> Hi,
> 
> On Tue, Jul 21, 2020 at 02:46:54PM -0300, Vitor Massaru Iha wrote:
> > This adds the conversion of the runtime tests of test_user_copy fuctions,
> > from `lib/test_user_copy.c`to KUnit tests.
> > 
> > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> 
> These tests are failing (at least) for arm-v7, loongarch, and mips
> qemu emulations; see below for failure logs.

Oh my. Good thing this got added to KUnit, then -- the core of the tests
haven't actually changed. I will see what I can uncover.

> Any idea if those might be architecture problems, problems with qemu,
> or problems with the test ?

The last two look like NULL derefs (??) and the first seems like maybe a
test problem (the failure looks kind of like the CONFIG_MMU=n cases that
were fixed earlier).

-- 
Kees Cook

      parent reply	other threads:[~2024-08-06 19:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 17:46 [PATCH v3] lib: Convert test_user_copy to KUnit test Vitor Massaru Iha
2020-07-21 19:09 ` Kees Cook
2020-07-21 22:19   ` Vitor Massaru Iha
2020-07-21 23:11     ` Vitor Massaru Iha
2020-07-22  2:12     ` Kees Cook
2020-07-22 18:29       ` Vitor Massaru Iha
2020-07-22 19:45         ` Kees Cook
2020-07-22 20:21           ` Vitor Massaru Iha
2020-07-22 22:28           ` Vitor Massaru Iha
2024-08-06 15:48 ` Guenter Roeck
2024-08-06 16:00   ` Guenter Roeck
2024-08-06 19:34   ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202408061232.B6382B6DA0@keescook \
    --to=kees@kernel.org \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=skhan@linuxfoundation.org \
    --cc=vitor@massaru.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox