From: Christoph Hellwig <hch@lst.de>
To: Rik van Riel <riel@surriel.com>
Cc: Christoph Hellwig <hch@lst.de>, Breno Leitao <leitao@debian.org>,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] dma,debug: avoid deadlock between dma debug vs printk and netcons
Date: Tue, 6 Aug 2024 14:38:38 +0200 [thread overview]
Message-ID: <20240806123838.GA9975@lst.de> (raw)
In-Reply-To: <20240805140844.6a863c76@imladris.surriel.com>
On Mon, Aug 05, 2024 at 02:08:44PM -0400, Rik van Riel wrote:
> index a6e3792b15f8..dc96e414be38 100644
> --- a/kernel/dma/debug.c
> +++ b/kernel/dma/debug.c
> @@ -417,7 +417,7 @@ static unsigned long long phys_addr(struct dma_debug_entry *entry)
> * other hand, consumes a single dma_debug_entry, but inserts 'nents'
> * entries into the tree.
> */
> -static RADIX_TREE(dma_active_cacheline, GFP_ATOMIC);
> +static RADIX_TREE(dma_active_cacheline, GFP_ATOMIC | __GFP_NOWARN);
This looks reasonable, but please add a comment here to explain why
this is using __GFP_NOWARN so that future readers don't have to wonder
about it and look into git history.
next prev parent reply other threads:[~2024-08-06 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 18:08 [PATCH] dma,debug: avoid deadlock between dma debug vs printk and netcons Rik van Riel
2024-08-06 12:38 ` Christoph Hellwig [this message]
2024-08-06 15:56 ` [PATCH v2] " Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806123838.GA9975@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=riel@surriel.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox