From: Jose Fernandez <jose.fernandez@linux.dev>
To: "Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Christian Heusel" <christian@heusel.eu>
Cc: Jose Fernandez <jose.fernandez@linux.dev>,
Peter Jung <ptr1337@cachyos.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] kbuild: control extra pacman packages with PACMAN_EXTRAPACKAGES
Date: Tue, 6 Aug 2024 20:27:18 -0600 [thread overview]
Message-ID: <20240807022718.24838-2-jose.fernandez@linux.dev> (raw)
Introduce a new variable, PACMAN_EXTRAPACKAGES, in the Makefile.package
to control the creation of additional packages by the pacman-pkg target.
The headers and api-headers packages will be included by default if
PACMAN_EXTRAPACKAGES is not set. This changes the previous behavior
where api-headers was always included, and headers was conditionally
included if CONFIG_MODULES=y. Now, this decision is delegated to the
user.
To disable extra packages, set PACMAN_EXTRAPACKAGES to an empty value:
make pacman-pkg PACMAN_EXTRAPACKAGES=
or
make pacman-pkg PACMAN_EXTRAPACKAGES=""
Signed-off-by: Jose Fernandez <jose.fernandez@linux.dev>
Reviewed-by: Peter Jung <ptr1337@cachyos.org>
---
v1 -> v2: Build all extra packages by default. Remove unnecessary lines.
In a previous patch, there was concern that adding a new debug package
would increase the package time. To address this concern and provide
more flexibility, this change has been added to allow users to decide
which extra packages to include before introducing an optional debug
package [1].
[1] https://lore.kernel.org/lkml/20240801192008.GA3923315@thelio-3990X/T/
scripts/Makefile.package | 2 ++
scripts/package/PKGBUILD | 11 +++++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/scripts/Makefile.package b/scripts/Makefile.package
index 4a80584ec771..ccdf8ba41f0b 100644
--- a/scripts/Makefile.package
+++ b/scripts/Makefile.package
@@ -144,6 +144,8 @@ snap-pkg:
# pacman-pkg
# ---------------------------------------------------------------------------
+PACMAN_EXTRAPACKAGES ?= headers api-headers
+
PHONY += pacman-pkg
pacman-pkg:
@ln -srf $(srctree)/scripts/package/PKGBUILD $(objtree)/PKGBUILD
diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
index 663ce300dd06..8de869f9b1d4 100644
--- a/scripts/package/PKGBUILD
+++ b/scripts/package/PKGBUILD
@@ -3,10 +3,13 @@
# Contributor: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
pkgbase=${PACMAN_PKGBASE:-linux-upstream}
-pkgname=("${pkgbase}" "${pkgbase}-api-headers")
-if grep -q CONFIG_MODULES=y include/config/auto.conf; then
- pkgname+=("${pkgbase}-headers")
-fi
+pkgname=("${pkgbase}")
+
+_extrapackages=${PACMAN_EXTRAPACKAGES:-}
+for pkg in $_extrapackages; do
+ pkgname+=("${pkgbase}-${pkg}")
+done
+
pkgver="${KERNELRELEASE//-/_}"
# The PKGBUILD is evaluated multiple times.
# Running scripts/build-version from here would introduce inconsistencies.
--
2.46.0
next reply other threads:[~2024-08-07 2:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 2:27 Jose Fernandez [this message]
2024-08-07 13:37 ` [PATCH v2] kbuild: control extra pacman packages with PACMAN_EXTRAPACKAGES Masahiro Yamada
2024-08-07 16:40 ` Thomas Weißschuh
2024-08-07 17:02 ` Masahiro Yamada
2024-08-07 17:31 ` Thomas Weißschuh
2024-08-10 0:16 ` Jose Fernandez
2024-08-10 7:41 ` Masahiro Yamada
2024-08-11 16:01 ` Jose Fernandez
2024-08-10 7:54 ` Thomas Weißschuh
2024-08-11 20:46 ` Jose Fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807022718.24838-2-jose.fernandez@linux.dev \
--to=jose.fernandez@linux.dev \
--cc=christian@heusel.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ptr1337@cachyos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox