From: Arnd Bergmann <arnd@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Joseph Strauss <jstrauss@mailbox.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Patrick Rudolph" <patrick.rudolph@9elements.com>,
"George Stark" <gnstark@salutedevices.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] leds: blinkm: fix CONFIG_LEDS_CLASS_MULTICOLOR dependency
Date: Wed, 7 Aug 2024 09:55:53 +0200 [thread overview]
Message-ID: <20240807075614.2118068-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
With CONFIG_LEDS_CLASS_MULTICOLOR=m, a builtin leds-blinkm driver causes
a link failure:
arm-linux-gnueabi-ld: drivers/leds/leds-blinkm.o: in function `blinkm_set_mc_brightness':
leds-blinkm.c:(.text.blinkm_set_mc_brightness+0xc): undefined reference to `led_mc_calc_color_components'
Add a more specific dependency that only allows multicoler mode to
be enabled for blinkm if it can build and link.
Fixes: 56e8c56c9af0 ("leds: Add multicolor support to BlinkM LED driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 41214c9b93ba..818c8bdd047e 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -838,7 +838,7 @@ config LEDS_BLINKM
config LEDS_BLINKM_MULTICOLOR
bool "Enable multicolor support for BlinkM I2C RGB LED"
depends on LEDS_BLINKM
- depends on LEDS_CLASS_MULTICOLOR
+ depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=LEDS_BLINKM
help
This option enables multicolor sysfs class support for BlinkM LED and
disables the older, separated sysfs interface
--
2.39.2
next reply other threads:[~2024-08-07 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 7:55 Arnd Bergmann [this message]
2024-08-07 18:14 ` [PATCH] leds: blinkm: fix CONFIG_LEDS_CLASS_MULTICOLOR dependency Joseph Strauss
2024-08-16 16:05 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807075614.2118068-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ansuelsmth@gmail.com \
--cc=arnd@arndb.de \
--cc=duje.mihanovic@skole.hr \
--cc=gnstark@salutedevices.com \
--cc=jernej.skrabec@gmail.com \
--cc=jstrauss@mailbox.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=patrick.rudolph@9elements.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox