public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
	Michal Hocko <mhocko@kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 14/19] mm: Create/affine kswapd to its preferred node
Date: Wed,  7 Aug 2024 18:02:20 +0200	[thread overview]
Message-ID: <20240807160228.26206-15-frederic@kernel.org> (raw)
In-Reply-To: <20240807160228.26206-1-frederic@kernel.org>

kswapd is dedicated to a specific node. As such it wants to be
preferrably affine to it, memory and CPUs-wise.

Use the proper kthread API to achieve that. As a bonus it takes care of
CPU-hotplug events and CPU-isolation on its behalf.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
 mm/vmscan.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index cfa839284b92..b8ee3bf8fa29 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -7159,10 +7159,6 @@ static int kswapd(void *p)
 	unsigned int highest_zoneidx = MAX_NR_ZONES - 1;
 	pg_data_t *pgdat = (pg_data_t *)p;
 	struct task_struct *tsk = current;
-	const struct cpumask *cpumask = cpumask_of_node(pgdat->node_id);
-
-	if (!cpumask_empty(cpumask))
-		set_cpus_allowed_ptr(tsk, cpumask);
 
 	/*
 	 * Tell the memory management that we're a "memory allocator",
@@ -7331,7 +7327,7 @@ void __meminit kswapd_run(int nid)
 
 	pgdat_kswapd_lock(pgdat);
 	if (!pgdat->kswapd) {
-		pgdat->kswapd = kthread_run(kswapd, pgdat, "kswapd%d", nid);
+		pgdat->kswapd = kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d", nid);
 		if (IS_ERR(pgdat->kswapd)) {
 			/* failure at boot is fatal */
 			pr_err("Failed to start kswapd on node %d,ret=%ld\n",
@@ -7339,6 +7335,7 @@ void __meminit kswapd_run(int nid)
 			BUG_ON(system_state < SYSTEM_RUNNING);
 			pgdat->kswapd = NULL;
 		}
+		wake_up_process(pgdat->kswapd);
 	}
 	pgdat_kswapd_unlock(pgdat);
 }
-- 
2.45.2


  parent reply	other threads:[~2024-08-07 16:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 16:02 [PATCH 00/19] kthread: Introduce preferred affinity v2 Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 01/19] arm/bL_switcher: Use kthread_run_on_cpu() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 02/19] x86/resctrl: " Frederic Weisbecker
2024-12-02 15:19   ` [tip: x86/cache] " tip-bot2 for Frederic Weisbecker
2024-12-13 21:02   ` tip-bot2 for Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 03/19] firmware: stratix10-svc: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 04/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 05/19] scsi: bnx2i: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 06/19] scsi: qedi: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 07/19] soc/qman: test: Use kthread_run_on_cpu() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 08/19] kallsyms: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 09/19] lib: test_objpool: " Frederic Weisbecker
2024-08-14  2:53   ` wuqiang.matt
2024-08-07 16:02 ` [PATCH 10/19] net: pktgen: Use kthread_create_on_node() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 11/19] kthread: Make sure kthread hasn't started while binding it Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-08-07 17:01   ` Vlastimil Babka
2024-08-07 16:02 ` [PATCH 13/19] mm: Create/affine kcompactd to its preferred node Frederic Weisbecker
2024-08-07 17:02   ` Vlastimil Babka
2024-08-07 16:02 ` Frederic Weisbecker [this message]
2024-08-07 17:05   ` [PATCH 14/19] mm: Create/affine kswapd " Vlastimil Babka
2024-08-07 16:02 ` [PATCH 15/19] kthread: Implement preferred affinity Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 16/19] rcu: Use kthread preferred affinity for RCU boost Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 17/19] kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 18/19] treewide: Introduce kthread_run_worker[_on_cpu]() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 19/19] rcu: Use kthread preferred affinity for RCU exp kworkers Frederic Weisbecker
  -- strict thread matches above, loose matches on Subject: below --
2024-09-16 22:49 [PATCH 00/19] kthread: Introduce preferred affinity v3 Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 14/19] mm: Create/affine kswapd to its preferred node Frederic Weisbecker
2024-09-17  6:05   ` Michal Hocko
2024-12-11 15:40 [PATCH 00/19] kthread: Introduce preferred affinity v6 Frederic Weisbecker
2024-12-11 15:40 ` [PATCH 14/19] mm: Create/affine kswapd to its preferred node Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807160228.26206-15-frederic@kernel.org \
    --to=frederic@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox