From: kernel test robot <lkp@intel.com>
To: Mary Guillemard <mary.guillemard@collabora.com>,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
dri-devel@lists.freedesktop.org, kernel@collabora.com,
Mary Guillemard <mary.guillemard@collabora.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Rob Herring <robh@kernel.org>,
Steven Price <steven.price@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters
Date: Thu, 8 Aug 2024 21:06:40 +0800 [thread overview]
Message-ID: <202408082014.XKxle32n-lkp@intel.com> (raw)
In-Reply-To: <20240807160900.149154-2-mary.guillemard@collabora.com>
Hi Mary,
kernel test robot noticed the following build errors:
[auto build test ERROR on f7f3ddb6e5c8dc7b621fd8c0903ea42190d67452]
url: https://github.com/intel-lab-lkp/linux/commits/Mary-Guillemard/drm-panfrost-Add-SYSTEM_TIMESTAMP-and-SYSTEM_TIMESTAMP_FREQUENCY-parameters/20240808-032938
base: f7f3ddb6e5c8dc7b621fd8c0903ea42190d67452
patch link: https://lore.kernel.org/r/20240807160900.149154-2-mary.guillemard%40collabora.com
patch subject: [PATCH 1/3] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240808/202408082014.XKxle32n-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408082014.XKxle32n-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408082014.XKxle32n-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/panfrost/panfrost_drv.c:75:18: error: implicit declaration of function '__arch_counter_get_cntvct' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
param->value = __arch_counter_get_cntvct();
^
>> drivers/gpu/drm/panfrost/panfrost_drv.c:83:18: error: implicit declaration of function 'arch_timer_get_cntfrq' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
param->value = arch_timer_get_cntfrq();
^
2 errors generated.
vim +/__arch_counter_get_cntvct +75 drivers/gpu/drm/panfrost/panfrost_drv.c
26
27 static int panfrost_ioctl_get_param(struct drm_device *ddev, void *data, struct drm_file *file)
28 {
29 struct drm_panfrost_get_param *param = data;
30 struct panfrost_device *pfdev = ddev->dev_private;
31
32 if (param->pad != 0)
33 return -EINVAL;
34
35 #define PANFROST_FEATURE(name, member) \
36 case DRM_PANFROST_PARAM_ ## name: \
37 param->value = pfdev->features.member; \
38 break
39 #define PANFROST_FEATURE_ARRAY(name, member, max) \
40 case DRM_PANFROST_PARAM_ ## name ## 0 ... \
41 DRM_PANFROST_PARAM_ ## name ## max: \
42 param->value = pfdev->features.member[param->param - \
43 DRM_PANFROST_PARAM_ ## name ## 0]; \
44 break
45
46 switch (param->param) {
47 PANFROST_FEATURE(GPU_PROD_ID, id);
48 PANFROST_FEATURE(GPU_REVISION, revision);
49 PANFROST_FEATURE(SHADER_PRESENT, shader_present);
50 PANFROST_FEATURE(TILER_PRESENT, tiler_present);
51 PANFROST_FEATURE(L2_PRESENT, l2_present);
52 PANFROST_FEATURE(STACK_PRESENT, stack_present);
53 PANFROST_FEATURE(AS_PRESENT, as_present);
54 PANFROST_FEATURE(JS_PRESENT, js_present);
55 PANFROST_FEATURE(L2_FEATURES, l2_features);
56 PANFROST_FEATURE(CORE_FEATURES, core_features);
57 PANFROST_FEATURE(TILER_FEATURES, tiler_features);
58 PANFROST_FEATURE(MEM_FEATURES, mem_features);
59 PANFROST_FEATURE(MMU_FEATURES, mmu_features);
60 PANFROST_FEATURE(THREAD_FEATURES, thread_features);
61 PANFROST_FEATURE(MAX_THREADS, max_threads);
62 PANFROST_FEATURE(THREAD_MAX_WORKGROUP_SZ,
63 thread_max_workgroup_sz);
64 PANFROST_FEATURE(THREAD_MAX_BARRIER_SZ,
65 thread_max_barrier_sz);
66 PANFROST_FEATURE(COHERENCY_FEATURES, coherency_features);
67 PANFROST_FEATURE(AFBC_FEATURES, afbc_features);
68 PANFROST_FEATURE_ARRAY(TEXTURE_FEATURES, texture_features, 3);
69 PANFROST_FEATURE_ARRAY(JS_FEATURES, js_features, 15);
70 PANFROST_FEATURE(NR_CORE_GROUPS, nr_core_groups);
71 PANFROST_FEATURE(THREAD_TLS_ALLOC, thread_tls_alloc);
72
73 case DRM_PANFROST_PARAM_SYSTEM_TIMESTAMP:
74 #ifdef CONFIG_ARM_ARCH_TIMER
> 75 param->value = __arch_counter_get_cntvct();
76 #else
77 param->value = 0;
78 #endif
79 break;
80
81 case DRM_PANFROST_PARAM_SYSTEM_TIMESTAMP_FREQUENCY:
82 #ifdef CONFIG_ARM_ARCH_TIMER
> 83 param->value = arch_timer_get_cntfrq();
84 #else
85 param->value = 0;
86 #endif
87 break;
88
89 default:
90 return -EINVAL;
91 }
92
93 return 0;
94 }
95
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-08-08 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 16:08 [PATCH 0/3] drm/panfrost: Wire cycle counters and timestamp info to userspace Mary Guillemard
2024-08-07 16:08 ` [PATCH 1/3] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters Mary Guillemard
2024-08-08 10:23 ` Steven Price
2024-08-08 10:46 ` Mary Guillemard
2024-08-08 13:06 ` kernel test robot [this message]
2024-08-07 16:08 ` [PATCH 2/3] drm/panfrost: Add cycle counter job requirement Mary Guillemard
2024-08-08 10:23 ` Steven Price
2024-08-07 16:08 ` [PATCH 3/3] drm/panfrost: Handle JD_REQ_CYCLE_COUNT Mary Guillemard
2024-08-08 10:23 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408082014.XKxle32n-lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mary.guillemard@collabora.com \
--cc=mripard@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox