Re: [PATCH v2 1/2] dt-bindings: power: Add support for RK3576 SoC

Conor Dooley
2024-08-12T16:19:17Z

[-- Attachment #1: Type: text/plain, Size: 3725 bytes --]

On Fri, Aug 09, 2024 at 01:27:18PM -0400, Detlev Casanova wrote:
> On Friday, 9 August 2024 10:59:58 EDT Conor Dooley wrote:
> > On Thu, Aug 08, 2024 at 12:31:04PM -0400, Detlev Casanova wrote:
> > > From: Finley Xiao <finley.xiao@rock-chips.com>
> > >
> > > Define power domain IDs as described in the TRM and add compatible for
> > > rockchip,rk3576-power-controller
> > >
> > > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> > > [reword, add yaml]
> >
> > To be honest, both here and in your other patch, you should remove this
> > [] section and add a co-develop-ed-by instead.
>
> That seems to be used quite often though, I like how it gives an idea of what
> has been adapted from downstream patches.

Right, but if you modified it, then why not be a co-author? IMO the []
is only suitable for when patches are modified between submission and
application by a maintainer and that anything else should be noted under
the --- line. If you feel like the difference to the vendor kernel is
worth having in the git history, it should be described in the commit
message itself and the reason should be meaningful (like the numbers
changed incompatibly) rather than that you did the minimum required for
a patch to be acceptable.

Cheers,
Conor.

>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > > ---
> > >
> > > .../power/rockchip,power-controller.yaml | 1 +
> > > .../dt-bindings/power/rockchip,rk3576-power.h | 30 +++++++++++++++++++
> > > 2 files changed, 31 insertions(+)
> > > create mode 100644 include/dt-bindings/power/rockchip,rk3576-power.h
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> > > b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> > > index 0d5e999a58f1b..650dc0aae6f51 100644
> > > ---
> > > a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> > > +++
> > > b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml>
> > > @@ -41,6 +41,7 @@ properties:
> > > - rockchip,rk3368-power-controller
> > > - rockchip,rk3399-power-controller
> > > - rockchip,rk3568-power-controller
> > >
> > > + - rockchip,rk3576-power-controller
> > >
> > > - rockchip,rk3588-power-controller
> > > - rockchip,rv1126-power-controller
> > >
> > > diff --git a/include/dt-bindings/power/rockchip,rk3576-power.h
> > > b/include/dt-bindings/power/rockchip,rk3576-power.h new file mode 100644
> > > index 0000000000000..324a056aa8512
> > > --- /dev/null
> > > +++ b/include/dt-bindings/power/rockchip,rk3576-power.h
> > > @@ -0,0 +1,30 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> > > +#ifndef __DT_BINDINGS_POWER_RK3576_POWER_H__
> > > +#define __DT_BINDINGS_POWER_RK3576_POWER_H__
> > > +
> > > +/* VD_NPU */
> > > +#define RK3576_PD_NPU 0
> > > +#define RK3576_PD_NPUTOP 1
> > > +#define RK3576_PD_NPU0 2
> > > +#define RK3576_PD_NPU1 3
> > > +
> > > +/* VD_GPU */
> > > +#define RK3576_PD_GPU 4
> > > +
> > > +/* VD_LOGIC */
> > > +#define RK3576_PD_NVM 5
> > > +#define RK3576_PD_SDGMAC 6
> > > +#define RK3576_PD_USB 7
> > > +#define RK3576_PD_PHP 8
> > > +#define RK3576_PD_SUBPHP 9
> > > +#define RK3576_PD_AUDIO 10
> > > +#define RK3576_PD_VEPU0 11
> > > +#define RK3576_PD_VEPU1 12
> > > +#define RK3576_PD_VPU 13
> > > +#define RK3576_PD_VDEC 14
> > > +#define RK3576_PD_VI 15
> > > +#define RK3576_PD_VO0 16
> > > +#define RK3576_PD_VO1 17
> > > +#define RK3576_PD_VOP 18
> > > +
> > > +#endif
>
>
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]