Re: [PATCH 1/1] tools/cpupower: display residency value in idle-info

Shuah Khan
2024-08-09T16:36:40Z

On 8/9/24 02:37, Aboorva Devarajan wrote:
> Update cpuidle tool to display the residency value of cpuidle
> states. This addition provides a clearer and more detailed view
> of idle state information when using cpuidle-info.
>
> --------------------------------
> Before Patch:
> --------------------------------
> $ cpupower idle-info
> CPUidle driver: intel_idle
> CPUidle governor: menu
> analyzing CPU 28:
>
> Number of idle states: 3
> Available idle states: POLL C1 C1E
> POLL:
> Flags/Description: CPUIDLE CORE POLL IDLE
> Latency: 0
> Usage: 7448
> Duration: 207170
> C1:
> Flags/Description: MWAIT 0x00
> Latency: 2
> Usage: 7023
> Duration: 3736853
> C1E:
> Flags/Description: MWAIT 0x01
> Latency: 10
> Usage: 18468
> Duration: 11396212
>
> --------------------------------
> After Patch:
> --------------------------------
> $ cpupower idle-info
> CPUidle driver: intel_idle
> CPUidle governor: menu
> analyzing CPU 12:
>
> Number of idle states: 3
> Available idle states: POLL C1 C1E
> POLL:
> Flags/Description: CPUIDLE CORE POLL IDLE
> Latency: 0
> Residency: 0
> Usage: 1950
> Duration: 38458
> C1:
> Flags/Description: MWAIT 0x00
> Latency: 2
> Residency: 2
> Usage: 10688
> Duration: 7133020
> C1E:
> Flags/Description: MWAIT 0x01
> Latency: 10
> Residency: 20
> Usage: 22356
> Duration: 15687259
> --------------------------------
>
> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> ---
> tools/power/cpupower/lib/cpuidle.c | 8 ++++++++
> tools/power/cpupower/lib/cpuidle.h | 2 ++
> tools/power/cpupower/utils/cpuidle-info.c | 4 ++++
> 3 files changed, 14 insertions(+)
>

Thank you for the patch. Applied for Linux 6.12 to

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower

I will send this in my PR to Rafael.

thanks,
-- Shuah