From: Ivor Wanders <ivor@iwanders.net>
To: konradybcio@kernel.org
Cc: hdegoede@redhat.com, ivor@iwanders.net, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, luzmaximilian@gmail.com
Subject: Re: [PATCH v2] hwmon: Add thermal sensor driver for Surface Aggregator Module
Date: Fri, 9 Aug 2024 20:34:35 -0400 [thread overview]
Message-ID: <20240810003435.10539-1-ivor@iwanders.net> (raw)
In-Reply-To: <6027d9db-b1a8-4eb0-a0b7-451f1524834c@kernel.org>
> Gave it a shot on SL7, some names are repeated and one sensor is totally busted
Interesting, thanks for testing. I'm not sure if this is the right place for discussing this, or
whether we should take this to the downstream thread (link in cover letter or in [2]).
I have duplicates for RTS{1..3} as well, so you're not alone there, for me it's also sensor 1 and 9
forming a duplicated name pair [1], this makes me wonder if the names are always of the form
`I_RTS#` where # is (id % 8 + 1), if that is the case for all surface models the names may not be
that much of a value add?
The surface diagnostics tool actually doesn't request these names: it has hardcoded names for just
three sensor ids that are part of the diagnostics [2], but I don't know if those three id's are
stable across the various devices though.
~Ivor
[1]: https://github.com/linux-surface/surface-aggregator-module/pull/68#issue-2054614428
[2]: https://github.com/linux-surface/surface-aggregator-module/issues/59#issuecomment-1974827016
next prev parent reply other threads:[~2024-08-10 0:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 23:08 [PATCH v2] hwmon: Add thermal sensor driver for Surface Aggregator Module Maximilian Luz
2024-08-06 19:41 ` kernel test robot
2024-08-07 0:32 ` Guenter Roeck
2024-08-07 19:25 ` Maximilian Luz
2024-08-07 19:50 ` Guenter Roeck
2024-08-07 20:11 ` Maximilian Luz
2024-08-07 20:37 ` Guenter Roeck
2024-08-10 1:19 ` Maximilian Luz
2024-08-09 23:35 ` Konrad Dybcio
2024-08-10 0:34 ` Ivor Wanders [this message]
2024-08-10 1:04 ` Maximilian Luz
2024-08-10 1:14 ` Konrad Dybcio
2024-08-19 10:26 ` Konrad Dybcio
2024-08-19 20:03 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240810003435.10539-1-ivor@iwanders.net \
--to=ivor@iwanders.net \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=konradybcio@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luzmaximilian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox