Re: [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet

Arun.Ramadoss
2024-08-12T10:46:03Z

Hi Pieter,

@@ -141,7 +141,7 @@ static struct sk_buff *ksz8795_rcv(struct sk_buff
> *skb, struct net_device *dev)
> {
> u8 *tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
>
> - return ksz_common_rcv(skb, dev, tag[0] & 7,
> KSZ_EGRESS_TAG_LEN);
> + return ksz_common_rcv(skb, dev, tag[0] & 3,
> KSZ_EGRESS_TAG_LEN);
> }

This change can be separate patch. since it is not related to
ksz87xx_dev_ops structure. Is it a fix or just good to have one. If it
is a fix then it should be point to net tree.

>
> static const struct dsa_device_ops ksz8795_netdev_ops = {
> --
> 2.43.0
>