Re: [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI

Simon Horman
2024-08-15T15:02:23Z

On Mon, Aug 12, 2024 at 04:04:37PM -0400, Sean Anderson wrote:
> Add support for IFF_ALLMULTI by configuring a single filter to match the
> multicast address bit. This allows us to keep promiscuous mode disabled,
> even when we have more than four multicast addresses. An even better
> solution would be to "pack" addresses into the available CAM registers,
> but that can wait for a future series.
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

My comment on patch 1/4 notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>