Re: [PATCH v2 4/7] usb: dwc3: core: Expose core driver as library

Bjorn Andersson
2024-08-19T21:35:36Z

On Tue, Aug 13, 2024 at 02:15:35PM -0400, Frank Li wrote:
> On Sun, Aug 11, 2024 at 08:12:01PM -0700, Bjorn Andersson wrote:
> > From: Bjorn Andersson <quic_bjorande@quicinc.com>
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
[..]
> > static const struct dev_pm_ops dwc3_dev_pm_ops = {
> > - SET_SYSTEM_SLEEP_PM_OPS(dwc3_suspend, dwc3_resume)
> > - .complete = dwc3_complete,
> > - SET_RUNTIME_PM_OPS(dwc3_runtime_suspend, dwc3_runtime_resume,
> > - dwc3_runtime_idle)
> > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_plat_suspend, dwc3_plat_resume)
>
> since you touch this line,
> suggest use new SYSTEM_SLEEP_PM_OPS() and RUNTIME_PM_OPS() help macro.
> also CONFIG_PM_SLEEP can be removed.
>

I'd be happy to follow up with such cleanups after we've concluded this,
I did spot a few other things that would benefit from some TLC.

Regards,
Bjorn