Re: [PATCH v2 4/7] usb: dwc3: core: Expose core driver as library

Thinh Nguyen
2024-08-14T01:01:23Z

On Tue, Aug 13, 2024, Frank Li wrote:
> On Sun, Aug 11, 2024 at 08:12:01PM -0700, Bjorn Andersson wrote:
> > From: Bjorn Andersson <quic_bjorande@quicinc.com>

...

> > +{
> > + dwc3_complete(dev_get_drvdata(dev));
> > +}
> > #else
> > -#define dwc3_complete NULL
> > +#define dwc3_plat_complete NULL
> > #endif /* CONFIG_PM_SLEEP */
> >
> > static const struct dev_pm_ops dwc3_dev_pm_ops = {
> > - SET_SYSTEM_SLEEP_PM_OPS(dwc3_suspend, dwc3_resume)
> > - .complete = dwc3_complete,
> > - SET_RUNTIME_PM_OPS(dwc3_runtime_suspend, dwc3_runtime_resume,
> > - dwc3_runtime_idle)
> > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_plat_suspend, dwc3_plat_resume)
>
> since you touch this line,
> suggest use new SYSTEM_SLEEP_PM_OPS() and RUNTIME_PM_OPS() help macro.
> also CONFIG_PM_SLEEP can be removed.
>

If we want to make that change, please keep that change separate from
this patch/series.

Thanks,
Thinh