Re: [PATCH v2 1/7] dt-bindings: usb: snps,dwc3: Split core description

Rob Herring
2024-08-18T14:33:45Z

On Sun, Aug 11, 2024 at 08:11:58PM -0700, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> The Synopsys DWC3 core is found either as a standard block or integrated
> with vendor glue logic. So far the latter has been described as two
> separate IP blocks in DeviceTree, but the two parts are not separate.
>
> In the case where the core is integrated together with vendor glue,
> resources such as clock and resets are often customized by the vendor,
> such that the standard properties doesn't make sense.
>
> Split the snps,dwc3 binding in a description of the core properties and
> the standard "glue" properties, in order to allow vendor bindings to
> inherit the core properties.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> .../devicetree/bindings/usb/snps,dwc3-common.yaml | 417 +++++++++++++++++++++
> .../devicetree/bindings/usb/snps,dwc3.yaml | 391 +------------------
> 2 files changed, 418 insertions(+), 390 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml
> new file mode 100644
> index 000000000000..65e7900f904a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml
> @@ -0,0 +1,417 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/snps,dwc3-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synopsys DesignWare USB3 Controller common properties
> +
> +select: false

You can drop this.

With that,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>