From: "José Expósito" <jose.exposito89@gmail.com>
To: rodrigosiqueiramelo@gmail.com
Cc: melissa.srw@gmail.com, mairacanal@riseup.net,
hamohammed.sa@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
louis.chauvet@bootlin.com,
"José Expósito" <jose.exposito89@gmail.com>
Subject: [RFC PATCH 00/17] VKMS: Add configfs support
Date: Tue, 13 Aug 2024 12:44:11 +0200 [thread overview]
Message-ID: <20240813105134.17439-1-jose.exposito89@gmail.com> (raw)
Hi everyone,
This RFC implements support to configure VKMS using configfs.
It allows to:
- Create multiple devices
- Configure multiple overlay planes, CRTCs, encoders and
connectors
- Enable or disable cursor plane and writeback connector for
each CRTC
- Hot-plug/unplug connectors after device creation
- Disable the creation of the default VKMS instance to be
able to use only the configfs ones
This work is based on a previous attempt to implement configfs
support by Jim Shargo and Brandon Pollack [1].
I tried to keep the changes as minimal and simple as possible
and addressed Sima's comments on [1].
Currently, there is another RFC by Louis Chauvet [2]. As I
mentioned on his RFC, I'm not trying to push my implementation.
Instead, I think that having 2 implementations will make code
review way easier and I don't mind which implementation is used
as long as we get the feature implemented :)
I'm looking forward to analyzing Louis's implementation, seeing
what the differences are and finding a common solution.
What's missing?
- DebugFS only works for the default VKMS instance.
If we want to support it on instances created with configfs
I'll need to implement it.
Known bugs:
- When a CRTC is added and removed before device creation, there
is a vblank warning.
The issue is caused because vblanks are referenced using the
CRTC index but, because one of the CRTCs is removed, the
indices are not consecutives and drm_crtc_vblank_crtc() tries to
access and invalid index
I'm not sure if CRTC's indices *must* start at 0 and be
consecutives or if this is a bug in the drm_crtc_vblank_crtc()
implementation.
Best wishes,
José Expósito
[1] https://patchwork.kernel.org/project/dri-devel/list/?series=780110&archive=both
[2] https://lore.kernel.org/dri-devel/ZrZZFQW5RiG12ApN@louis-chauvet-laptop/T/#u
José Expósito (17):
drm/vkms: Extract vkms_config header
drm/vkms: Move default_config creation to its own function
drm/vkms: Set device name from vkms_config
drm/vkms: Allow to configure multiple CRTCs
drm/vkms: Use managed memory to create encoders
drm/vkms: Allow to configure multiple encoders
drm/vkms: Use managed memory to create connectors
drm/vkms: Allow to configure multiple connectors
drm/vkms: Allow to configure multiple overlay planes
drm/vkms: Allow to change connector status
drm/vkms: Add and remove VKMS instances via configfs
drm/vkms: Allow to configure multiple CRTCs via configfs
drm/vkms: Allow to configure multiple encoders via configfs
drm/vkms: Allow to configure multiple encoders
drm/vkms: Allow to configure multiple planes via configfs
drm/vkms: Allow to configure the default device creation
drm/vkms: Remove completed task from the TODO list
Documentation/gpu/vkms.rst | 102 +++-
drivers/gpu/drm/vkms/Kconfig | 1 +
drivers/gpu/drm/vkms/Makefile | 4 +-
drivers/gpu/drm/vkms/vkms_composer.c | 30 +-
drivers/gpu/drm/vkms/vkms_config.c | 265 ++++++++++
drivers/gpu/drm/vkms/vkms_config.h | 101 ++++
drivers/gpu/drm/vkms/vkms_configfs.c | 721 ++++++++++++++++++++++++++
drivers/gpu/drm/vkms/vkms_configfs.h | 9 +
drivers/gpu/drm/vkms/vkms_crtc.c | 99 ++--
drivers/gpu/drm/vkms/vkms_drv.c | 75 ++-
drivers/gpu/drm/vkms/vkms_drv.h | 52 +-
drivers/gpu/drm/vkms/vkms_output.c | 187 ++++---
drivers/gpu/drm/vkms/vkms_plane.c | 6 +-
drivers/gpu/drm/vkms/vkms_writeback.c | 27 +-
14 files changed, 1464 insertions(+), 215 deletions(-)
create mode 100644 drivers/gpu/drm/vkms/vkms_config.c
create mode 100644 drivers/gpu/drm/vkms/vkms_config.h
create mode 100644 drivers/gpu/drm/vkms/vkms_configfs.c
create mode 100644 drivers/gpu/drm/vkms/vkms_configfs.h
--
2.46.0
next reply other threads:[~2024-08-13 10:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 10:44 José Expósito [this message]
2024-08-13 10:44 ` [RFC PATCH 01/17] drm/vkms: Extract vkms_config header José Expósito
2024-08-13 10:44 ` [RFC PATCH 02/17] drm/vkms: Move default_config creation to its own function José Expósito
2024-08-13 10:44 ` [RFC PATCH 03/17] drm/vkms: Set device name from vkms_config José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 04/17] drm/vkms: Allow to configure multiple CRTCs José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 05/17] drm/vkms: Use managed memory to create encoders José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 06/17] drm/vkms: Allow to configure multiple encoders José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 07/17] drm/vkms: Use managed memory to create connectors José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 08/17] drm/vkms: Allow to configure multiple connectors José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 09/17] drm/vkms: Allow to configure multiple overlay planes José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 10/17] drm/vkms: Allow to change connector status José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 11/17] drm/vkms: Add and remove VKMS instances via configfs José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 12/17] drm/vkms: Allow to configure multiple CRTCs " José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 13/17] drm/vkms: Allow to configure multiple encoders " José Expósito
2024-08-13 17:58 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 14/17] drm/vkms: Allow to configure multiple encoders José Expósito
2024-08-13 17:59 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 15/17] drm/vkms: Allow to configure multiple planes via configfs José Expósito
2024-08-13 17:59 ` Louis Chauvet
2024-08-13 10:44 ` [RFC PATCH 16/17] drm/vkms: Allow to configure the default device creation José Expósito
2024-08-13 10:44 ` [RFC PATCH 17/17] drm/vkms: Remove completed task from the TODO list José Expósito
2024-08-13 17:58 ` [RFC PATCH 00/17] VKMS: Add configfs support Louis Chauvet
2024-08-20 15:52 ` José Expósito
2024-08-14 9:10 ` Daniel Stone
2024-08-20 16:03 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813105134.17439-1-jose.exposito89@gmail.com \
--to=jose.exposito89@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox