Re: [PATCH net-next v2 1/2] net: phy: Add phy library support to check supported list when autoneg is enabled

Jakub Kicinski
2024-08-16T18:18:12Z

On Tue, 13 Aug 2024 23:45:14 +0530 Divya Koppera wrote:
> - if (autoneg == AUTONEG_ENABLE && linkmode_empty(advertising))
> + if (autoneg == AUTONEG_ENABLE &&
> + (linkmode_empty(advertising) ||
> + !(linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> + phydev->supported))))

nti: no need to wrap the linkmode_test_bit() in brackets:

!linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
phydev->supported)))

otherwise LGTM.

Please try to put links to previous versions into the cover letter.
--
pw-bot: cr