Re: [PATCH v2 19/36] soc: fsl: cpm1: qmc: Fix blank line and spaces

Christophe Leroy
2024-08-23T08:07:33Z

Le 08/08/2024 à 09:11, Herve Codina a écrit :
> checkpatch.pl raises the following issues
> CHECK: Please don't use multiple blank lines
> CHECK: Alignment should match open parenthesis
>
> Fix them.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> drivers/soc/fsl/qe/qmc.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index e2ac3e59bb79..44bd9b949770 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -274,7 +274,6 @@ static void qmc_setbits32(void __iomem *addr, u32 set)
> qmc_write32(addr, qmc_read32(addr) | set);
> }
>
> -
> int qmc_chan_get_info(struct qmc_chan *chan, struct qmc_chan_info *info)
> {
> struct tsa_serial_info tsa_info;
> @@ -1411,7 +1410,7 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan)
> qmc_write32(chan->s_param + QMC_SPE_ZDSTATE, 0x00000080);
> qmc_write16(chan->s_param + QMC_SPE_MFLR, 60);
> qmc_write16(chan->s_param + QMC_SPE_CHAMR,
> - QMC_SPE_CHAMR_MODE_HDLC | QMC_SPE_CHAMR_HDLC_IDLM);
> + QMC_SPE_CHAMR_MODE_HDLC | QMC_SPE_CHAMR_HDLC_IDLM);
> }
>
> /* Do not enable interrupts now. They will be enabled later */
> @@ -1604,7 +1603,6 @@ static int qmc_probe(struct platform_device *pdev)
> if (IS_ERR(qmc->scc_regs))
> return PTR_ERR(qmc->scc_regs);
>
> -
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "scc_pram");
> if (!res)
> return -EINVAL;
> @@ -1650,7 +1648,7 @@ static int qmc_probe(struct platform_device *pdev)
> */
> qmc->bd_size = (nb_chans * (QMC_NB_TXBDS + QMC_NB_RXBDS)) * sizeof(cbd_t);
> qmc->bd_table = dmam_alloc_coherent(qmc->dev, qmc->bd_size,
> - &qmc->bd_dma_addr, GFP_KERNEL);
> + &qmc->bd_dma_addr, GFP_KERNEL);
> if (!qmc->bd_table) {
> dev_err(qmc->dev, "Failed to allocate bd table\n");
> ret = -ENOMEM;
> @@ -1663,7 +1661,7 @@ static int qmc_probe(struct platform_device *pdev)
> /* Allocate the interrupt table */
> qmc->int_size = QMC_NB_INTS * sizeof(u16);
> qmc->int_table = dmam_alloc_coherent(qmc->dev, qmc->int_size,
> - &qmc->int_dma_addr, GFP_KERNEL);
> + &qmc->int_dma_addr, GFP_KERNEL);
> if (!qmc->int_table) {
> dev_err(qmc->dev, "Failed to allocate interrupt table\n");
> ret = -ENOMEM;
> @@ -1711,7 +1709,7 @@ static int qmc_probe(struct platform_device *pdev)
>
> /* Enable interrupts */
> qmc_write16(qmc->scc_regs + SCC_SCCM,
> - SCC_SCCE_IQOV | SCC_SCCE_GINT | SCC_SCCE_GUN | SCC_SCCE_GOV);
> + SCC_SCCE_IQOV | SCC_SCCE_GINT | SCC_SCCE_GUN | SCC_SCCE_GOV);
>
> ret = qmc_finalize_chans(qmc);
> if (ret < 0)