Re: [PATCH v2 17/36] soc: fsl: cpm1: qmc: Rename QMC_TSA_MASK

Christophe Leroy
2024-08-23T08:09:36Z

Le 08/08/2024 à 09:11, Herve Codina a écrit :
> QMC_TSA_MASK is a bitfield. The value defined is a specific value of
> this bitfield and correspond to the use of 8bit resolution for the
> routing entry.
>
> Be accurate and rename the defined constant to reflect this point.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> drivers/soc/fsl/qe/qmc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 916395745850..721e0770510c 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -77,7 +77,7 @@
> /* TSA entry (16bit entry in TSATRX and TSATTX) */
> #define QMC_TSA_VALID (1 << 15)
> #define QMC_TSA_WRAP (1 << 14)
> -#define QMC_TSA_MASK (0x303F)
> +#define QMC_TSA_MASK_8BIT (0x303F)
> #define QMC_TSA_CHANNEL(x) ((x) << 6)
>
> /* Tx buffer descriptor base address (16 bits, offset from MCBASE) */
> @@ -641,7 +641,7 @@ static int qmc_chan_setup_tsa_64rxtx(struct qmc_chan *chan, const struct tsa_ser
> return -EINVAL;
> }
>
> - val = QMC_TSA_VALID | QMC_TSA_MASK | QMC_TSA_CHANNEL(chan->id);
> + val = QMC_TSA_VALID | QMC_TSA_MASK_8BIT | QMC_TSA_CHANNEL(chan->id);
>
> /* Check entries based on Rx stuff*/
> for (i = 0; i < info->nb_rx_ts; i++) {
> @@ -677,7 +677,7 @@ static int qmc_chan_setup_tsa_32rx(struct qmc_chan *chan, const struct tsa_seria
>
> /* Use a Rx 32 entries table */
>
> - val = QMC_TSA_VALID | QMC_TSA_MASK | QMC_TSA_CHANNEL(chan->id);
> + val = QMC_TSA_VALID | QMC_TSA_MASK_8BIT | QMC_TSA_CHANNEL(chan->id);
>
> /* Check entries based on Rx stuff */
> for (i = 0; i < info->nb_rx_ts; i++) {
> @@ -713,7 +713,7 @@ static int qmc_chan_setup_tsa_32tx(struct qmc_chan *chan, const struct tsa_seria
>
> /* Use a Tx 32 entries table */
>
> - val = QMC_TSA_VALID | QMC_TSA_MASK | QMC_TSA_CHANNEL(chan->id);
> + val = QMC_TSA_VALID | QMC_TSA_MASK_8BIT | QMC_TSA_CHANNEL(chan->id);
>
> /* Check entries based on Tx stuff */
> for (i = 0; i < info->nb_tx_ts; i++) {