Re: [PATCH v2 03/36] soc: fsl: cpm1: tsa: Fix tsa_write8()

Christophe Leroy
2024-08-23T08:04:11Z

Le 08/08/2024 à 09:10, Herve Codina a écrit :
> The tsa_write8() parameter is an u32 value. This is not consistent with
> the function itself. Indeed, tsa_write8() writes an 8bits value.
>
> Be consistent and use an u8 parameter value.
>
> Fixes: 1d4ba0b81c1c ("soc: fsl: cpm1: Add support for TSA")
> Cc: stable@vger.kernel.org
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> drivers/soc/fsl/qe/tsa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
> index 6c5741cf5e9d..53968ea84c88 100644
> --- a/drivers/soc/fsl/qe/tsa.c
> +++ b/drivers/soc/fsl/qe/tsa.c
> @@ -140,7 +140,7 @@ static inline void tsa_write32(void __iomem *addr, u32 val)
> iowrite32be(val, addr);
> }
>
> -static inline void tsa_write8(void __iomem *addr, u32 val)
> +static inline void tsa_write8(void __iomem *addr, u8 val)
> {
> iowrite8(val, addr);
> }