Re: [PATCH v2 28/36] soc: fsl: cpm1: qmc: Rename qmc_chan_command()

Christophe Leroy
2024-08-23T08:12:59Z

Le 08/08/2024 à 09:11, Herve Codina a écrit :
> Current code handles CPM1 version of QMC and qmc_chan_command() is
> clearly CPM1 specific.
>
> In order to prepare the support for the QUICC Engine (QE) version,
> rename qmc_chan_command() to reflect that point.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> drivers/soc/fsl/qe/qmc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index b95227378f97..272da250a763 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -794,7 +794,7 @@ static int qmc_chan_setup_tsa_rx(struct qmc_chan *chan, bool enable)
> return qmc_chan_setup_tsa_32rx(chan, &info, enable);
> }
>
> -static int qmc_chan_command(struct qmc_chan *chan, u8 qmc_opcode)
> +static int qmc_chan_cpm1_command(struct qmc_chan *chan, u8 qmc_opcode)
> {
> return cpm_command(chan->id << 2, (qmc_opcode << 4) | 0x0E);
> }
> @@ -813,7 +813,7 @@ static int qmc_chan_stop_rx(struct qmc_chan *chan)
> }
>
> /* Send STOP RECEIVE command */
> - ret = qmc_chan_command(chan, 0x0);
> + ret = qmc_chan_cpm1_command(chan, 0x0);
> if (ret) {
> dev_err(chan->qmc->dev, "chan %u: Send STOP RECEIVE failed (%d)\n",
> chan->id, ret);
> @@ -850,7 +850,7 @@ static int qmc_chan_stop_tx(struct qmc_chan *chan)
> }
>
> /* Send STOP TRANSMIT command */
> - ret = qmc_chan_command(chan, 0x1);
> + ret = qmc_chan_cpm1_command(chan, 0x1);
> if (ret) {
> dev_err(chan->qmc->dev, "chan %u: Send STOP TRANSMIT failed (%d)\n",
> chan->id, ret);