Re: [PATCH v2 06/36] soc: fsl: cpm1: tsa: Add missing spinlock comment

Christophe Leroy
2024-08-23T08:05:08Z

Le 08/08/2024 à 09:10, Herve Codina a écrit :
> checkpatch.pl raises the following issue
> CHECK: spinlock_t definition without comment
>
> Add the missing comment.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> drivers/soc/fsl/qe/tsa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
> index 7b1032fb1572..a9d35b44489d 100644
> --- a/drivers/soc/fsl/qe/tsa.c
> +++ b/drivers/soc/fsl/qe/tsa.c
> @@ -128,7 +128,7 @@ struct tsa {
> void __iomem *si_regs;
> void __iomem *si_ram;
> resource_size_t si_ram_sz;
> - spinlock_t lock;
> + spinlock_t lock; /* Lock for read/modify/write sequence */
> int tdms; /* TSA_TDMx ORed */
> struct tsa_tdm tdm[2]; /* TDMa and TDMb */
> struct tsa_serial {