From: Conor Dooley <conor@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>,
Diogo Ivo <diogo.ivo@siemens.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Date: Wed, 14 Aug 2024 15:26:45 +0100 [thread overview]
Message-ID: <20240814-passable-phrasing-7e78fce590f5@spud> (raw)
In-Reply-To: <a838d867-def7-49f8-b9cf-9f4d638ff2d6@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]
On Wed, Aug 14, 2024 at 06:49:39AM +0200, Jan Kiszka wrote:
> On 13.08.24 17:40, Conor Dooley wrote:
> > On Tue, Aug 13, 2024 at 08:04:59AM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Expand bindings to cover both the MCU and the main usage of the AM654
> >> system controller.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >> .../soc/ti/ti,am654-system-controller.yaml | 25 +++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> index e79803e586ca..5a689ec3c5c9 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> @@ -29,11 +29,36 @@ properties:
> >>
> >> ranges: true
> >>
> >> + mux-controller:
> >> + type: object
> >> + ref: /schemas/mux/reg-mux.yaml#
> >> + description:
> >> + This is the SERDES lane control mux.
> >> +
> >> patternProperties:
> >> "^phy@[0-9a-f]+$":
> >> type: object
> >> $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
> >>
> >> + "^clock@[0-9a-f]+$":
> >
> > Could you explain to me why these are all patternProperties? Why are the
> > addresses of these things not fixed for an am654?
> >
>
> I could indeed spell out dss-oldi-io-ctrl@41e0 and
> clock-controller@4140, and their addresses are likely fixed, indeed. But
> there are also clock@4080 and clock@4090 - should I duplicate their
> object descriptions while moving them to the regular properties?
If you're going to itemise the 3 clocks, I think you should mention
what's different about each of them. Otherwise, if they're all
identical, leave them as a patternProperty.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-08-14 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 6:04 [PATCH v3 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings Jan Kiszka
2024-08-13 6:04 ` [PATCH v3 1/3] arm64: dts: ti: k3-am642-evm: Silence schema warning Jan Kiszka
2024-08-13 6:04 ` [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain Jan Kiszka
2024-08-13 15:40 ` Conor Dooley
2024-08-14 4:49 ` Jan Kiszka
2024-08-14 14:26 ` Conor Dooley [this message]
2024-08-13 6:05 ` [PATCH v3 3/3] arm64: dts: ti: k3-am65-main: add system controller compatible Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814-passable-phrasing-7e78fce590f5@spud \
--to=conor@kernel.org \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox