public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: bajing <bajing@cmss.chinamobile.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
	nicolas@fjasle.eu, masahiroy@kernel.org,
	speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: genmap: initialization the variable
Date: Wed, 14 Aug 2024 08:01:09 +0200	[thread overview]
Message-ID: <20240814060109.sh34huizfjramdce@begin> (raw)
In-Reply-To: <20240814030243.2138-1-bajing@cmss.chinamobile.com>

bajing, le mer. 14 août 2024 11:02:43 +0800, a ecrit:
> The variable lc is not initialized before use, so the initialization operation on it is added.
> 
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
> ---
>  drivers/accessibility/speakup/genmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0882bab10fb8..a1ea0ce45c20 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -48,7 +48,7 @@ static int get_shift_value(int state)
>  int
>  main(int argc, char *argv[])
>  {
> -	int value, shift_state, i, spk_val = 0, lock_val = 0;
> +	int value, shift_state, i, lc, spk_val = 0, lock_val = 0;

You have already sent a patch that does drop the use before
initialization.

Samuel

>  	int max_key_used = 0, num_keys_used = 0;
>  	struct st_key *this;
>  	struct st_key_init *p_init;
> -- 
> 2.33.0
> 
> 
> 

-- 
Samuel
 Cliquez sur le lien qui suit dans ce mail...vous n'avez plus qu'a vous
 inscrire pour gagner de l'argent en restant connecte....et puis faites
 passer le message et vous gagnerez encore plus d'argent ...
 -+- AC in NPC : Neuneu a rencontré le Pere Noël -+-

  reply	other threads:[~2024-08-14  6:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  3:02 [PATCH] speakup: genmap: initialization the variable bajing
2024-08-14  6:01 ` Samuel Thibault [this message]
2024-08-15  3:47 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814060109.sh34huizfjramdce@begin \
    --to=samuel.thibault@ens-lyon.org \
    --cc=bajing@cmss.chinamobile.com \
    --cc=chris@the-brannons.com \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox