Re: [PATCH 02/19] mm: Drop is_huge_zero_pud()

Jason Gunthorpe
2024-08-14T12:38:20Z

On Fri, Aug 09, 2024 at 12:08:52PM -0400, Peter Xu wrote:
> It constantly returns false since 2017. One assertion is added in 2019 but
> it should never have triggered, IOW it means what is checked should be
> asserted instead.
>
> If it didn't exist for 7 years maybe it's good idea to remove it and only
> add it when it comes.
>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> include/linux/huge_mm.h | 10 ----------
> mm/huge_memory.c | 13 +------------
> 2 files changed, 1 insertion(+), 22 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason