Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

Daniel Almeida
2024-07-13T01:00:50Z

Hi Dave,

>
> I think I'm on the uapi should remain in C for now, we define uapi
> types with the kernel types and we have downstream tools to scan and
> parse them to deal with alignments and padding (I know FEX relies on
> it), so I think we should be bindgen from uapi headers into rust for
> now. There might be a future where this changes, but that isn't now
> and I definitely don't want to mix C and rust uapi in one driver.
>
> Dave.

Yeah, once this was mentioned:

> How do we (easily) verify that changes in the Rust code don't break the uAPI by
> due to leading to changes in the generated header files?
>
> Do we have guarantees that future releases of cbindgen can't break anything?

I realized that there would be issues with my original approach.

> I think I'm on the uapi should remain in C for now

No worries, I will fix this in v2.

— Daniel