Re: [PATCH v11 03/10] spi: Add multi-cs memories support in SPI core

Mark Brown
2024-01-21T01:04:29Z

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

On Sat, Jan 20, 2024 at 09:05:43AM -0800, Guenter Roeck wrote:

> FWIW, the problem is due to

> +#define SPI_CS_CNT_MAX 4

> in the offending patch, but apeed2400 FMC supports up to 5 SPI chip selects.
>
> static const struct aspeed_spi_data ast2400_fmc_data = {
> .max_cs = 5,
> ^^^^^^^^^^^^^^^^^^^
> .hastype = true,

> Limiting .max_cs to 4 or increasing SPI_CS_CNT_MAX to 5 fixes the problem,
> though of course I don't know if increasing SPI_CS_CNT_MAX has other side
> effects.

Yeah, I was coming to a similar conclusion myself - the limit is just
too low. I can't see any problem with increasing it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]