Re: [PATCH 3/9] memory: samsung: exynos5422-dmc: use scoped device node handling to simplify error paths

Krzysztof Kozlowski
2024-08-14T17:57:22Z

On 14/08/2024 18:42, Jonathan Cameron wrote:
> On Mon, 12 Aug 2024 15:33:57 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> Obtain the device node reference with scoped/cleanup.h to reduce error
>> handling and make the code a bit simpler.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Trivial comments inline
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
>> ---
>> drivers/memory/samsung/exynos5422-dmc.c | 31 +++++++++++--------------------
>> 1 file changed, 11 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
>> index da7ecd921c72..d3ae4d95a3ba 100644
>> --- a/drivers/memory/samsung/exynos5422-dmc.c
>> +++ b/drivers/memory/samsung/exynos5422-dmc.c
>> @@ -4,6 +4,7 @@
>> * Author: Lukasz Luba <l.luba@partner.samsung.com>
>> */
>>
>> +#include <linux/cleanup.h>
>> #include <linux/clk.h>
>> #include <linux/devfreq.h>
>> #include <linux/devfreq-event.h>
>> @@ -1176,10 +1177,10 @@ static int of_get_dram_timings(struct exynos5_dmc *dmc)
>> {
>> int ret = 0;
>> int idx;
>> - struct device_node *np_ddr;
>
> This would definitely benefit from a
> struct device *dev = dmc->dev;

True, I'll do it in separate patch.

>
>> u32 freq_mhz, clk_period_ps;
>>
>> - np_ddr = of_parse_phandle(dmc->dev->of_node, "device-handle", 0);
>> + struct device_node *np_ddr __free(device_node) = of_parse_phandle(dmc->dev->of_node,
>> + "device-handle", 0);
> Trivial. Maybe consider the wrap suggested in patch 1.
>> + struct device_node *np_ddr __free(device_node) =
> of_parse_phandle(dmc->dev->of_node, "device-handle", 0);

Ack.

Best regards,
Krzysztof