From: Jason Andryuk <jason.andryuk@amd.com>
To: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Brian Gerst <brgerst@gmail.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
"Jason Andryuk" <jason.andryuk@amd.com>
Subject: [PATCH v2 0/5] x86/pvh: Make 64bit PVH entry relocatable
Date: Wed, 14 Aug 2024 15:50:48 -0400 [thread overview]
Message-ID: <20240814195053.5564-1-jason.andryuk@amd.com> (raw)
Using the PVH entry point, the uncompressed vmlinux is loaded at
LOAD_PHYSICAL_ADDR, and execution starts in 32bit mode at the
address in XEN_ELFNOTE_PHYS32_ENTRY, pvh_start_xen, with paging
disabled.
Loading at LOAD_PHYSICAL_ADDR has not been a problem in the past as
virtual machines don't have conflicting memory maps. But Xen now
supports a PVH dom0, which uses the host memory map, and there are
Coreboot/EDK2 firmwares that have reserved regions conflicting with
LOAD_PHYSICAL_ADDR. Xen recently added XEN_ELFNOTE_PHYS32_RELOC to
specify an alignment, minimum and maximum load address when
LOAD_PHYSICAL_ADDR cannot be used. This patch series makes the PVH
entry path PIC to support relocation.
Only x86-64 is converted. The 32bit entry path calling into vmlinux,
which is not PIC, will not support relocation.
The entry path needs pages tables to switch to 64bit mode. A new
pvh_init_top_pgt is added to make the transition into the startup_64
when the regular init_top_pgt pagetables are setup. This duplication is
unfortunate, but it keeps the changes simpler. __startup_64() can't be
used to setup init_top_pgt for PVH entry because it is 64bit code - the
32bit entry code doesn't have page tables to use.
This is the straight forward implementation to make it work. Other
approaches could be pursued.
checkpatch.pl gives an error: "ERROR: Macros with multiple statements
should be enclosed in a do - while loop" about the moved PMDS macro.
But PMDS is an assembler macro, so its not applicable. There are some
false positive warnings "WARNING: space prohibited between function name
and open parenthesis '('" about the macro, too.
v2 addresses review feedback. It also replace LOAD_PHYSICAL_ADDR with
_pa(pvh_start_xen) in some offset calculations. They happened to be
equal in my original builds. When the two values differ,
_pa(pvh_start_xen) is the correct one to use.
Jason Andryuk (5):
xen: sync elfnote.h from xen tree
x86/pvh: Make PVH entrypoint PIC for x86-64
x86/pvh: Set phys_base when calling xen_prepare_pvh()
x86/kernel: Move page table macros to header
x86/pvh: Add 64bit relocation page tables
arch/x86/include/asm/pgtable_64.h | 23 ++++-
arch/x86/kernel/head_64.S | 20 ----
arch/x86/platform/pvh/head.S | 161 +++++++++++++++++++++++++++---
include/xen/interface/elfnote.h | 93 ++++++++++++++++-
4 files changed, 259 insertions(+), 38 deletions(-)
--
2.34.1
next reply other threads:[~2024-08-14 19:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 19:50 Jason Andryuk [this message]
2024-08-14 19:50 ` [PATCH v2 1/5] xen: sync elfnote.h from xen tree Jason Andryuk
2024-08-14 19:50 ` [PATCH v2 2/5] x86/pvh: Make PVH entrypoint PIC for x86-64 Jason Andryuk
2024-08-14 19:50 ` [PATCH v2 3/5] x86/pvh: Set phys_base when calling xen_prepare_pvh() Jason Andryuk
2024-08-14 19:50 ` [PATCH v2 4/5] x86/kernel: Move page table macros to header Jason Andryuk
2024-08-15 7:07 ` Juergen Gross
2024-08-14 19:50 ` [PATCH v2 5/5] x86/pvh: Add 64bit relocation page tables Jason Andryuk
2024-08-15 22:55 ` kernel test robot
2024-08-16 1:39 ` kernel test robot
2024-08-16 2:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814195053.5564-1-jason.andryuk@amd.com \
--to=jason.andryuk@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=pbonzini@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox