From: Wei Fang <wei.fang@nxp.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
hkallweit1@gmail.com, linux@armlinux.org.uk,
andrei.botila@oss.nxp.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/3] dt-bindings: net: tja11xx: use reverse-mode to instead of rmii-refclk-in
Date: Thu, 15 Aug 2024 13:51:24 +0800 [thread overview]
Message-ID: <20240815055126.137437-2-wei.fang@nxp.com> (raw)
In-Reply-To: <20240815055126.137437-1-wei.fang@nxp.com>
Per the MII and RMII specifications, for the standard RMII mode,
the REF_CLK is sourced from MAC to PHY or from an external source.
For the standard MII mode, the RX_CLK and TX_CLK are both sourced
by the PHY. But for TJA11xx PHYs, they support reverse mode, that
is, for revRMII mode, the REF_CLK is output, and for revMII mode,
the TX_CLK and RX_CLK are inputs to the PHY.
Previously the "nxp,rmii-refclk-in" was added to indicate that in
RMII mode, if this property present, REF_CLK is input to the PHY,
otherwise it is output. This seems inappropriate now. Firstly, for
the standard RMII mode, REF_CLK is originally input, and there is
no need to add the "nxp,rmii-refclk-in" property to indicate that
REF_CLK is input. Secondly, this property is not generic for TJA
PHYs, because it cannot cover the settings of TX_CLK and RX_CLK in
MII mode. Therefore, add new property "nxp,reverse-mode" to instead
of the "nxp,rmii-refclk-in" property.
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
.../devicetree/bindings/net/nxp,tja11xx.yaml | 21 +++++++------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
index 85bfa45f5122..e8ab2cf8d4d4 100644
--- a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
+++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
@@ -32,21 +32,14 @@ patternProperties:
description:
The ID number for the child PHY. Should be +1 of parent PHY.
- nxp,rmii-refclk-in:
+ nxp,reverse-mode:
type: boolean
description: |
- The REF_CLK is provided for both transmitted and received data
- in RMII mode. This clock signal is provided by the PHY and is
- typically derived from an external 25MHz crystal. Alternatively,
- a 50MHz clock signal generated by an external oscillator can be
- connected to pin REF_CLK. A third option is to connect a 25MHz
- clock to pin CLK_IN_OUT. So, the REF_CLK should be configured
- as input or output according to the actual circuit connection.
- If present, indicates that the REF_CLK will be configured as
- interface reference clock input when RMII mode enabled.
- If not present, the REF_CLK will be configured as interface
- reference clock output when RMII mode enabled.
- Only supported on TJA1100 and TJA1101.
+ If present, the TJA11xx PHY will operate in "reversed" role mode.
+ If XMII_MODE is set to MII, the device operates in revMII mode
+ (TXCLK and RXCLK are input).
+ If XMII_MODE is set to RMII, the device operates in revRMII mode
+ (REF_CLK is output).
required:
- reg
@@ -61,7 +54,7 @@ examples:
tja1101_phy0: ethernet-phy@4 {
reg = <0x4>;
- nxp,rmii-refclk-in;
+ nxp,reverse-mode;
};
};
- |
--
2.34.1
next prev parent reply other threads:[~2024-08-15 6:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 5:51 [PATCH net-next 0/3] add "nxp,reverse-mode" to instead of "nxp,rmii-refclk-in" Wei Fang
2024-08-15 5:51 ` Wei Fang [this message]
2024-08-15 14:33 ` [PATCH net-next 1/3] dt-bindings: net: tja11xx: use reverse-mode to instead of rmii-refclk-in Andrew Lunn
2024-08-16 1:39 ` Wei Fang
2024-08-16 2:32 ` Andrew Lunn
2024-08-16 2:57 ` Wei Fang
2024-08-16 3:28 ` Andrew Lunn
2024-08-16 5:01 ` Wei Fang
2024-08-20 5:13 ` Wei Fang
2024-08-20 13:25 ` Andrew Lunn
2024-08-21 1:40 ` Wei Fang
2024-08-15 5:51 ` [PATCH net-next 2/3] net: phy: tja11xx: replace "nxp,rmii-refclk-in" with "nxp,reverse-mode" Wei Fang
2024-08-15 13:37 ` Simon Horman
2024-08-15 5:51 ` [PATCH net-next 3/3] net: phy: c45-tja11xx: add revRMII mode support Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815055126.137437-2-wei.fang@nxp.com \
--to=wei.fang@nxp.com \
--cc=andrei.botila@oss.nxp.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox