From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BE6F15E5D6 for ; Thu, 15 Aug 2024 07:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723706988; cv=none; b=dUG/Ybk8SGgox/Bhow+fxpF7i+dDDYq6EF55U0ynfs2R8qcl5CRonKdfibriudGgZnhFE9goEtJXERP+8VppouyvYjYnZfaV3jskJSwr59igNdRGPCG4QvnzoDW34QriumZiIGJBNlj/cP82jD+tqolYC81J93dFYskA/RReHi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723706988; c=relaxed/simple; bh=hPX1celK2r4ELG+EKPXeAClu4f8aV/KAzwDNQ2P/imE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BZSm/517m7CZsQHs6PZXUDBDc77qr+Kb8yCmIUCpqETQvmHnJtEnWBHCZ8XELw+rdWukPMcbAQlyq2vgmgekM2avbm6X2tSgsNiQ+7blYE3Fb5mXfsjPulFlzHCKKnYmRNU2T2THCHUd0vx5sEmtJ4N+R38IWGE6MltZ/8gTPd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ak1x0BR4; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ak1x0BR4" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3db51133978so395744b6e.3 for ; Thu, 15 Aug 2024 00:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723706984; x=1724311784; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EwP1Gv/Yx/xpl+pnVih7/w3vpScHL1lhIFF+Jyhxw7M=; b=Ak1x0BR4TtlYd5wFix/qt3t0aDEzhwxVLrirTJtyNmYzslnKpF+wdwpy9oXIe41w+6 3/s6pKqsbl0c/SMYvRm2fPsiuQfWzl10JappVmN7TOTeUsfLRBUQo0XAJ3u9/qN/o5tv Hm9HjZ6ZGSj8myiJb+rktiFvw+Mq3U0S1pAnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723706984; x=1724311784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EwP1Gv/Yx/xpl+pnVih7/w3vpScHL1lhIFF+Jyhxw7M=; b=HJE78zLQcMpdy/tSXZjw+nSXEFhSn8BvTPhz9qs97Op9ZkxT8zYHcCO4JSpnoLfZij 1X/7w1wCsNV3ayjKWv/6sVktdhGwDvxc+rezjf1Adh09nQA+tzaRNTlg2rwY+6VDrH/y 4/wMoUuUId4H6MhCzcTsw9IkLFsYW4c4SLapE4bFNR/Xi7KMSWCr6Kq+/C2fgkpZEax7 o2ilp58sxTA1QsXTUQHPfOPm6Dx0IIPK49cweBBleBGg0DsfNeDj1ejKALjedBkwuqSR sPp+jh/x5FFluodTCM9/P32rdpzusyBWwbyUlInFdnJzpl062m7KFGlWFZ1h5fHcHnXy ZjCg== X-Forwarded-Encrypted: i=1; AJvYcCVFwWhzyYU5ISsEK7NgT92yNwETTR7MVnFLDjpVUk1fePSkKb7PRErM1Y/sns87LzdmmahHSdzOZxTq5ZQ7AOJsgD+0iUDOQ2cIzO+r X-Gm-Message-State: AOJu0Yx1s+H+dC9727bm9vuVXcpwIsb7cKi1n0wR3xLLC5K2ebEHtCus 0kq9RINrPrMlUmzBp1tm4w9vyvcpbJZu+pndkgUIqH6sjveR6O8nRee6roHo1g== X-Google-Smtp-Source: AGHT+IGmv5LKc/rdRpi8Ra9/RsIMunAWATmlN37PMZ/4ZdYVF8yC6fAOhJyK+4vfrUac1BNWQewwDg== X-Received: by 2002:a05:6808:1821:b0:3da:aae9:717b with SMTP id 5614622812f47-3dd299929c7mr6326564b6e.45.1723706984412; Thu, 15 Aug 2024 00:29:44 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:745d:58f7:b3cd:901f]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7c6b61a6d98sm524661a12.11.2024.08.15.00.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 00:29:43 -0700 (PDT) Date: Thu, 15 Aug 2024 15:29:38 +0800 From: Chen-Yu Tsai To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Amit Kucheria , Thara Gopinath , Thierry Reding , Jonathan Hunter , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 5/7] thermal: qcom-spmi-adc-tm5: Simplify with scoped for each OF child loop Message-ID: <20240815072938.GE350960@google.com> References: <20240814-b4-cleanup-h-of-node-put-thermal-v1-0-7a1381e1627e@linaro.org> <20240814-b4-cleanup-h-of-node-put-thermal-v1-5-7a1381e1627e@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814-b4-cleanup-h-of-node-put-thermal-v1-5-7a1381e1627e@linaro.org> On Wed, Aug 14, 2024 at 10:17:51PM +0200, Krzysztof Kozlowski wrote: > Use scoped for_each_available_child_of_node_scoped() when iterating over > device nodes to make code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai > --- > drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > index 7c9f4023babc..19cdb98c310e 100644 > --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c > @@ -938,7 +938,6 @@ static const struct adc_tm5_data adc_tm5_gen2_data_pmic = { > static int adc_tm5_get_dt_data(struct adc_tm5_chip *adc_tm, struct device_node *node) > { > struct adc_tm5_channel *channels; > - struct device_node *child; > u32 value; > int ret; > struct device *dev = adc_tm->dev; > @@ -982,12 +981,10 @@ static int adc_tm5_get_dt_data(struct adc_tm5_chip *adc_tm, struct device_node * > adc_tm->avg_samples = VADC_DEF_AVG_SAMPLES; > } > > - for_each_available_child_of_node(node, child) { > + for_each_available_child_of_node_scoped(node, child) { > ret = adc_tm5_get_dt_channel_data(adc_tm, channels, child); > - if (ret) { > - of_node_put(child); > + if (ret) > return ret; > - } > > channels++; > } > > -- > 2.43.0 >