Re: [PATCH 6/7] thermal: tegra: Simplify with scoped for each OF child loop

Chen-Yu Tsai
2024-08-15T07:31:06Z

On Wed, Aug 14, 2024 at 10:17:52PM +0200, Krzysztof Kozlowski wrote:
> Use scoped for_each_child_of_node_scoped() when iterating over device
> nodes to make code a bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

> ---
> drivers/thermal/tegra/soctherm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
> index a023c948afbd..ff4eedb553fb 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -1651,7 +1651,7 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct tegra_soctherm *ts = dev_get_drvdata(dev);
> - struct device_node *np_stc, *np_stcc;
> + struct device_node *np_stc;
> const char *name;
> int i;
>
> @@ -1668,7 +1668,7 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
> return;
> }
>
> - for_each_child_of_node(np_stc, np_stcc) {
> + for_each_child_of_node_scoped(np_stc, np_stcc) {
> struct soctherm_throt_cfg *stc;
> struct thermal_cooling_device *tcd;
> int err;
> @@ -1683,7 +1683,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
>
> if (stc->init) {
> dev_err(dev, "throttle-cfg: %s: redefined!\n", name);
> - of_node_put(np_stcc);
> break;
> }
>
>
> --
> 2.43.0
>