From: Jacob Pan <jacob.pan@linux.microsoft.com>
To: Tina Zhang <tina.zhang@intel.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Kevin Tian <kevin.tian@intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] iommu/vt-d: Introduce batched cache invalidation
Date: Fri, 16 Aug 2024 09:38:46 -0700 [thread overview]
Message-ID: <20240816093846.40dbd623@DESKTOP-0403QTC.> (raw)
In-Reply-To: <20240815065221.50328-5-tina.zhang@intel.com>
On Thu, 15 Aug 2024 14:52:21 +0800
Tina Zhang <tina.zhang@intel.com> wrote:
> @@ -270,7 +343,8 @@ static void cache_tag_flush_iotlb(struct
> dmar_domain *domain, struct cache_tag * u64 type = DMA_TLB_PSI_FLUSH;
>
> if (domain->use_first_level) {
> - qi_flush_piotlb(iommu, tag->domain_id, tag->pasid,
> addr, pages, ih);
> + qi_batch_add_piotlb(iommu, tag->domain_id,
> tag->pasid, addr,
> + pages, ih, domain->qi_batch);
> return;
> }
>
> @@ -287,7 +361,8 @@ static void cache_tag_flush_iotlb(struct
> dmar_domain *domain, struct cache_tag * }
>
> if (ecap_qis(iommu->ecap))
> - qi_flush_iotlb(iommu, tag->domain_id, addr | ih,
> mask, type);
> + qi_batch_add_iotlb(iommu, tag->domain_id, addr | ih,
> mask, type,
> + domain->qi_batch);
>
If I understand this correctly, IOTLB flush maybe deferred until the
batch array is full, right? If so, is there a security gap where
callers think the mapping is gone after the call returns?
next prev parent reply other threads:[~2024-08-16 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 6:52 [PATCH v3 0/4] Batch IOTLB/dev-IOTLB invalidation Tina Zhang
2024-08-15 6:52 ` [PATCH v3 1/4] iommu/vt-d: Factor out invalidation descriptor composition Tina Zhang
2024-08-15 6:52 ` [PATCH v3 2/4] iommu/vt-d: Refactor IOTLB and Dev-IOTLB flush for batching Tina Zhang
2024-08-15 6:52 ` [PATCH v3 3/4] iommu/vt-d: Add qi_batch for dmar_domain Tina Zhang
2024-08-15 6:52 ` [PATCH v3 4/4] iommu/vt-d: Introduce batched cache invalidation Tina Zhang
2024-08-16 16:38 ` Jacob Pan [this message]
2024-08-17 3:28 ` Baolu Lu
2024-08-19 7:58 ` Yi Liu
2024-08-19 15:53 ` Jacob Pan
2024-08-19 15:40 ` Jacob Pan
2024-08-20 2:06 ` Baolu Lu
2024-08-20 23:04 ` Jacob Pan
2024-09-02 2:32 ` [PATCH v3 0/4] Batch IOTLB/dev-IOTLB invalidation Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816093846.40dbd623@DESKTOP-0403QTC. \
--to=jacob.pan@linux.microsoft.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox