* [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties
@ 2024-08-12 19:36 Frank Li
2024-08-13 2:32 ` Liu Ying
2024-08-16 22:05 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Frank Li @ 2024-08-12 19:36 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liu Ying, Thierry Reding,
Sam Ravnborg, open list:DRM PANEL DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Replace additionalProperties with unevaluatedProperties because it ref to
panel-common.yaml.
Remove properties (backlight, enable-gpios and power-supply), which defined
in panel-common.yaml.
Fix below warning:
arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
index e78160d1aa24c..10ed4b57232b9 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
@@ -84,11 +84,7 @@ properties:
- port@0
- port@1
- backlight: true
- enable-gpios: true
- power-supply: true
-
-additionalProperties: false
+unevaluatedProperties: false
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties
2024-08-12 19:36 [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties Frank Li
@ 2024-08-13 2:32 ` Liu Ying
2024-08-13 3:44 ` Frank Li
2024-08-16 22:05 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Liu Ying @ 2024-08-13 2:32 UTC (permalink / raw)
To: Frank Li, Neil Armstrong, Jessica Zhang, David Airlie,
Daniel Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Sam Ravnborg, open list:DRM PANEL DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 08/13/2024, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it ref to
> panel-common.yaml.
This would allow all properties in panel-common.yaml, which is not expected.
Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough?
>
> Remove properties (backlight, enable-gpios and power-supply), which defined
> in panel-common.yaml.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> index e78160d1aa24c..10ed4b57232b9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> @@ -84,11 +84,7 @@ properties:
> - port@0
> - port@1
>
> - backlight: true
> - enable-gpios: true
> - power-supply: true
> -
> -additionalProperties: false
> +unevaluatedProperties: false
>
> required:
> - compatible
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties
2024-08-13 2:32 ` Liu Ying
@ 2024-08-13 3:44 ` Frank Li
2024-08-13 9:08 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Frank Li @ 2024-08-13 3:44 UTC (permalink / raw)
To: Liu Ying
Cc: Neil Armstrong, Jessica Zhang, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Sam Ravnborg,
open list:DRM PANEL DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote:
> On 08/13/2024, Frank Li wrote:
> > Replace additionalProperties with unevaluatedProperties because it ref to
> > panel-common.yaml.
>
> This would allow all properties in panel-common.yaml, which is not expected.
> Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough?
Strange, you ref to panel-common.yaml, suppose it will use all common
preperties.
Krzysztof Kozlowski:
Can I just add panel-timing:true for this case?
Frank
>
> >
> > Remove properties (backlight, enable-gpios and power-supply), which defined
> > in panel-common.yaml.
> >
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
> > from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > index e78160d1aa24c..10ed4b57232b9 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > @@ -84,11 +84,7 @@ properties:
> > - port@0
> > - port@1
> >
> > - backlight: true
> > - enable-gpios: true
> > - power-supply: true
> > -
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >
> > required:
> > - compatible
>
> --
> Regards,
> Liu Ying
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties
2024-08-13 3:44 ` Frank Li
@ 2024-08-13 9:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-13 9:08 UTC (permalink / raw)
To: Frank Li, Liu Ying
Cc: Neil Armstrong, Jessica Zhang, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Sam Ravnborg,
open list:DRM PANEL DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On 13/08/2024 05:44, Frank Li wrote:
> On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote:
>> On 08/13/2024, Frank Li wrote:
>>> Replace additionalProperties with unevaluatedProperties because it ref to
>>> panel-common.yaml.
>>
>> This would allow all properties in panel-common.yaml, which is not expected.
>> Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough?
>
> Strange, you ref to panel-common.yaml, suppose it will use all common
> preperties.
>
> Krzysztof Kozlowski:
>
> Can I just add panel-timing:true for this case?
Yes, although I would claim that most of the panel-common schema also
applies here...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties
2024-08-12 19:36 [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties Frank Li
2024-08-13 2:32 ` Liu Ying
@ 2024-08-16 22:05 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-08-16 22:05 UTC (permalink / raw)
To: Frank Li
Cc: Neil Armstrong, Jessica Zhang, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Krzysztof Kozlowski, Conor Dooley, Liu Ying, Thierry Reding,
Sam Ravnborg, open list:DRM PANEL DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Mon, Aug 12, 2024 at 03:36:26PM -0400, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it ref to
> panel-common.yaml.
>
> Remove properties (backlight, enable-gpios and power-supply), which defined
> in panel-common.yaml.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Actually, I prefer doing it this way. Applied.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-16 22:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 19:36 [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties Frank Li
2024-08-13 2:32 ` Liu Ying
2024-08-13 3:44 ` Frank Li
2024-08-13 9:08 ` Krzysztof Kozlowski
2024-08-16 22:05 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox