Re: [PATCH 6.10 000/263] 6.10.5-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Aug 16, 2024 at 10:38:08AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 15, 2024 at 07:21:00AM -0700, Guenter Roeck wrote:
> > On 8/12/24 09:00, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.10.5 release.
> > > There are 263 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Wed, 14 Aug 2024 16:00:26 +0000.
> > > Anything received after that time might be too late.
> > > 
> > 
> > I see various allmodconfig build failures on v6.10.5.
> > 
> > Example from arm:
> > 
> > Building arm:allmodconfig ... failed
> > --------------
> > Error log:
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1581:13: error: 'is_dsc_common_config_possible' defined but not used [-Werror=unused-function]
> >  1581 | static bool is_dsc_common_config_possible(struct dc_stream_state *stream,
> >       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1569:21: error: 'kbps_from_pbn' defined but not used [-Werror=unused-function]
> >  1569 | static unsigned int kbps_from_pbn(unsigned int pbn)
> > 
> > The functions are built and used conditionally in mainline, behind CONFIG_DRM_AMD_DC_FP.
> > The conditional is missing in v6.10.5 (and v6.10.6-rc1).
> 
> Odd that other allmodconfig builds passed :(
> 
> I'll dig up where that conditional showed up, thanks for letting us
> know....
> 
> Ah, looks like it showed up in 00c391102abc ("drm/amd/display: Add misc
> DC changes for DCN401"), gotta love "fix a bunch of things" type of
> commits...

And that commit is crazy, and no way will it backport, so I'll just go
do this "by hand".  People who approved that commit need to revisit how
to create changes properly...

greg k-h