From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 715AA224D1; Sat, 17 Aug 2024 08:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723884174; cv=none; b=TqmRYJp7JUzg1C+AXhoQnoQ2nqm+Oet1nMWY60OXPe3qK98egLHKfQ+dOTGgxCrR4eal7zmL2qSztdPXN5JhZ6mavGcJQOQaZAIPG9a/ZNN2J2gdMBl7DPqW2TkvgBM58tedp+UOtUnt+oXZv7CYaWgQBYU0o03JdDGdkQvvLgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723884174; c=relaxed/simple; bh=wCPDpgJU3wZjcbdksuUtn6o6BHEmcbYJwksedTAOdnk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oqkp+tRfGM4DqjLDNl+DzJ0RAII7TQ+2CCHrndElI+ej0xZdJpiP6vFYstrcgHdMVQZUzf0zmjnA011keeKEoqvvXD4Dr9apczbFrzbpO16mDIt1ezPwi9CiivZFkyJo2/yApVLVvxw/l0pHki4AB7pf4NI9fj0ZJnWxAiLC3Tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jrf2ipw+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jrf2ipw+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 765E7C116B1; Sat, 17 Aug 2024 08:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723884173; bh=wCPDpgJU3wZjcbdksuUtn6o6BHEmcbYJwksedTAOdnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jrf2ipw+XP2hHIoE9izV0sNQF5Nl4z321jHbyn0zWZPoZqPL1LR02dn/0ycdsYPSK hNCp7UJ6cf+jtTaAIWFzs5JOehixXWZND8OCkVRRgV5H22njOjNNr5IZJwcoZ78M21 fESXQWNCsepCSQQsZRxrfoW/kfbb/ovifwsYjtxo= Date: Sat, 17 Aug 2024 10:42:51 +0200 From: Greg KH To: Kevin Holm Cc: stable@vger.kernel.org, regressions@lists.linux.dev, amd-gfx@lists.freedesktop.org, ML dri-devel , LKML , Wayne Lin , Jerry Zuo , Zaeem Mohamed , Daniel Wheeler , Alex Deucher Subject: Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode() Message-ID: <2024081739-suburb-manor-e6c3@gregkh> References: <20240730185339.543359-1-kevin@holm.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240730185339.543359-1-kevin@holm.dev> On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > From: Wayne Lin > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] > > [Why] > dm_dp_mst_is_port_support_mode() is a bit not following the original design rule and cause > light up issue with multiple 4k monitors after mst dsc hub. > > [How] > Refactor function dm_dp_mst_is_port_support_mode() a bit to solve the light up issue. > > Reviewed-by: Jerry Zuo > Acked-by: Zaeem Mohamed > Signed-off-by: Wayne Lin > Tested-by: Daniel Wheeler > Signed-off-by: Alex Deucher > [kevin@holm.dev: Resolved merge conflict in .../amdgpu_dm_mst_types.c] > Fixes: 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for mst mode validation") > Link: https://lore.kernel.org/stable/d74a7768e957e6ce88c27a5bece0c64dff132e24@holm.dev/T/#u > Signed-off-by: Kevin Holm > --- > I resolved the merge conflict so that, after this patch is applied to the > linux-6.10.y branch of the stable git repository, the resulting function > dm_dp_mst_is_port_support_mode (and also the new function > dp_get_link_current_set_bw) is identical to the original commit. > > I've confirmed that it fixes the regression I reported for my use case. And it turns out this change breaks the arm and arm64 builds. I tried to fix it up by applying the fixup afterward for this file, but it's just too much of a mess to unwind this, so I'm going to have to revert this now, sorry. See: https://lore.kernel.org/r/b27c5434-f1b1-4697-985b-91bb3e9a22df@roeck-us.net for details. greg k-h