From: kernel test robot <lkp@intel.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Theodore Ts'o <tytso@mit.edu>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Andy Lutomirski <luto@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: oe-kbuild-all@lists.linux.dev,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 9/9] selftests: [NOT TO BE MERGED] Modifications for testing VDSO getrandom implementation on PPC32
Date: Sun, 18 Aug 2024 02:07:08 +0800 [thread overview]
Message-ID: <202408180121.HB9iN2PQ-lkp@intel.com> (raw)
In-Reply-To: <376843e024ffa73793e8ed99b72d299c6b239799.1723817900.git.christophe.leroy@csgroup.eu>
Hi Christophe,
kernel test robot noticed the following build warnings:
[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes shuah-kselftest/next shuah-kselftest/fixes linus/master v6.11-rc3]
[cannot apply to crng-random/master next-20240816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/powerpc-vdso-Don-t-discard-rela-sections/20240816-223917
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/376843e024ffa73793e8ed99b72d299c6b239799.1723817900.git.christophe.leroy%40csgroup.eu
patch subject: [PATCH 9/9] selftests: [NOT TO BE MERGED] Modifications for testing VDSO getrandom implementation on PPC32
config: x86_64-randconfig-161-20240817 (https://download.01.org/0day-ci/archive/20240818/202408180121.HB9iN2PQ-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408180121.HB9iN2PQ-lkp@intel.com/
smatch warnings:
kernel/time/time.c:622 timespec64_to_jiffies() warn: always true condition '(sec >= ((((((((2147483647 >> 1) - 1) >> (32 - 10)) * ((1000000000 + 1000 / 2) / 1000)) / (1000000000)) << (1)) + (((((((2147483647 >> 1) - 1) >> (32 - 10)) * ((1000000000 + 1000 / 2) / 1000)) % (1000000000)) << (1)) + (1000000000) / 2) / (1000000000)) - 1)) => (0-u64max >= 0)'
vim +622 kernel/time/time.c
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 595
67b3f564cb1e769 kernel/time/time.c Randy Dunlap 2023-07-03 596 /**
67b3f564cb1e769 kernel/time/time.c Randy Dunlap 2023-07-03 597 * timespec64_to_jiffies - convert a timespec64 value to jiffies
67b3f564cb1e769 kernel/time/time.c Randy Dunlap 2023-07-03 598 * @value: pointer to &struct timespec64
67b3f564cb1e769 kernel/time/time.c Randy Dunlap 2023-07-03 599 *
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 600 * The TICK_NSEC - 1 rounds up the value to the next resolution. Note
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 601 * that a remainder subtract here would not do the right thing as the
4bf07f6562a01a4 kernel/time/time.c Ingo Molnar 2021-03-22 602 * resolution values don't fall on second boundaries. I.e. the line:
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 603 * nsec -= nsec % TICK_NSEC; is NOT a correct resolution rounding.
d78c9300c51d6ce kernel/time/time.c Andrew Hunter 2014-09-04 604 * Note that due to the small error in the multiplier here, this
d78c9300c51d6ce kernel/time/time.c Andrew Hunter 2014-09-04 605 * rounding is incorrect for sufficiently large values of tv_nsec, but
d78c9300c51d6ce kernel/time/time.c Andrew Hunter 2014-09-04 606 * well formed timespecs should have tv_nsec < NSEC_PER_SEC, so we're
d78c9300c51d6ce kernel/time/time.c Andrew Hunter 2014-09-04 607 * OK.
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 608 *
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 609 * Rather, we just shift the bits off the right.
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 610 *
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 611 * The >> (NSEC_JIFFIE_SC - SEC_JIFFIE_SC) converts the scaled nsec
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 612 * value to a scaled second value.
67b3f564cb1e769 kernel/time/time.c Randy Dunlap 2023-07-03 613 *
67b3f564cb1e769 kernel/time/time.c Randy Dunlap 2023-07-03 614 * Return: jiffies value
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 615 */
751addac78b6f20 kernel/time/time.c Arnd Bergmann 2019-10-24 616 unsigned long
751addac78b6f20 kernel/time/time.c Arnd Bergmann 2019-10-24 617 timespec64_to_jiffies(const struct timespec64 *value)
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 618 {
751addac78b6f20 kernel/time/time.c Arnd Bergmann 2019-10-24 619 u64 sec = value->tv_sec;
751addac78b6f20 kernel/time/time.c Arnd Bergmann 2019-10-24 620 long nsec = value->tv_nsec + TICK_NSEC - 1;
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 621
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 @622 if (sec >= MAX_SEC_IN_JIFFIES){
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 623 sec = MAX_SEC_IN_JIFFIES;
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 624 nsec = 0;
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 625 }
9ca308506062fc4 kernel/time/time.c Baolin Wang 2015-07-29 626 return ((sec * SEC_CONVERSION) +
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 627 (((u64)nsec * NSEC_CONVERSION) >>
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 628 (NSEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
8b9365d753d9870 kernel/time.c Ingo Molnar 2007-02-16 629
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-08-17 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 14:36 [PATCH 0/9] Wire up getrandom() vDSO implementation on powerpc Christophe Leroy
2024-08-16 14:36 ` [PATCH 1/9] powerpc/vdso: Don't discard rela sections Christophe Leroy
2024-08-16 14:36 ` [PATCH 2/9] powerpc/vdso32: Add crtsavres Christophe Leroy
2024-08-16 14:36 ` [PATCH 3/9] vdso: Add __arch_get_k_vdso_rng_data() Christophe Leroy
2024-08-17 12:48 ` kernel test robot
2024-08-17 13:19 ` kernel test robot
2024-08-16 14:36 ` [PATCH 4/9] vdso: Add missing c-getrandom-y in Makefile Christophe Leroy
2024-08-16 14:36 ` [PATCH 5/9] vdso: Avoid call to memset() by getrandom Christophe Leroy
2024-08-16 14:36 ` [PATCH 6/9] vdso: Only use MAP_DROPPABLE when VM_DROPPABLE exists Christophe Leroy
2024-08-16 14:36 ` [PATCH 7/9] powerpc: Add little endian variants of LHZX_BE and friends Christophe Leroy
2024-08-16 14:36 ` [PATCH 8/9] powerpc/vdso: Wire up getrandom() vDSO implementation Christophe Leroy
2024-08-16 14:36 ` [PATCH 9/9] selftests: [NOT TO BE MERGED] Modifications for testing VDSO getrandom implementation on PPC32 Christophe Leroy
2024-08-17 18:07 ` kernel test robot [this message]
2024-08-16 21:57 ` [PATCH 0/9] Wire up getrandom() vDSO implementation on powerpc Jason A. Donenfeld
2024-08-16 22:10 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408180121.HB9iN2PQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jason@zx2c4.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox