From: Waiman Long <longman@redhat.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>
Cc: linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>
Subject: [PATCH 3/3] sched/isolation: Consolidate housekeeping cpumasks that are always identical
Date: Sun, 18 Aug 2024 19:45:20 -0400 [thread overview]
Message-ID: <20240818234520.90186-4-longman@redhat.com> (raw)
In-Reply-To: <20240818234520.90186-1-longman@redhat.com>
The housekeeping cpumasks are only set by two boot commandline
parameters: "nohz_full" and "isolcpus". When there is more than one of
"nohz_full" or "isolcpus", the extra ones must have the same CPU list
or the setup will fail partially.
The HK_TYPE_TICK, HK_TYPE_DOMAIN and HK_TYPE_MANAGED_IRQ types are
settable by "isolcpus" and they can be set individually. The other
housekeeping types are all set by "nohz_full" without a way to set them
individually. So they all have identical cpumasks.
There is actually no point to have different cpumasks for these
"nohz_full" only housekeeping types. Consolidate these types to use the
same cpumask by aliasing them to the same value. If there is a need to
set any of them independently in the future, we can break them out to
their own cpumasks again.
With this change, the number of cpumasks in the housekeeping structure
drops from 9 to 4.
Signed-off-by: Waiman Long <longman@redhat.com>
---
include/linux/sched/isolation.h | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h
index 2b461129d1fa..da32b502f0c6 100644
--- a/include/linux/sched/isolation.h
+++ b/include/linux/sched/isolation.h
@@ -7,15 +7,22 @@
#include <linux/tick.h>
enum hk_type {
- HK_TYPE_TIMER,
- HK_TYPE_RCU,
- HK_TYPE_MISC,
- HK_TYPE_SCHED,
HK_TYPE_TICK,
HK_TYPE_DOMAIN,
- HK_TYPE_WQ,
HK_TYPE_MANAGED_IRQ,
- HK_TYPE_KTHREAD,
+ HK_TYPE_NOHZ_FULL,
+
+ /*
+ * The following housekeeping types are only set by the nohz_full
+ * boot commandline option. So they can share the same value.
+ */
+ HK_TYPE_TIMER = HK_TYPE_NOHZ_FULL,
+ HK_TYPE_RCU = HK_TYPE_NOHZ_FULL,
+ HK_TYPE_MISC = HK_TYPE_NOHZ_FULL,
+ HK_TYPE_SCHED = HK_TYPE_NOHZ_FULL,
+ HK_TYPE_WQ = HK_TYPE_NOHZ_FULL,
+ HK_TYPE_KTHREAD = HK_TYPE_NOHZ_FULL,
+
HK_TYPE_MAX
};
--
2.43.5
next prev parent reply other threads:[~2024-08-18 23:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 23:45 [PATCH 0/3] sched: Miscellaneous isolation related cleanups Waiman Long
2024-08-18 23:45 ` [PATCH 1/3] sched/isolation: Add HK_FLAG_SCHED to nohz_full Waiman Long
2024-09-03 13:10 ` Frederic Weisbecker
2024-09-03 13:24 ` Waiman Long
2024-09-03 21:32 ` Frederic Weisbecker
2024-09-04 1:23 ` Waiman Long
2024-09-04 12:44 ` Frederic Weisbecker
2024-09-04 13:04 ` Peter Zijlstra
2024-09-04 13:41 ` Waiman Long
2024-09-04 13:44 ` Phil Auld
2024-09-04 14:02 ` Peter Zijlstra
2024-09-04 14:32 ` Phil Auld
2024-09-04 14:09 ` Waiman Long
2024-09-06 12:36 ` Frederic Weisbecker
2024-08-18 23:45 ` [PATCH 2/3] sched/fair: Use HK_TYPE_SCHED housekeeping CPUs Waiman Long
2024-09-03 13:12 ` Frederic Weisbecker
2024-09-03 13:53 ` Waiman Long
2024-09-04 14:54 ` Waiman Long
2024-09-06 12:53 ` Frederic Weisbecker
2024-09-06 16:31 ` Waiman Long
2024-08-18 23:45 ` Waiman Long [this message]
2024-08-23 18:23 ` [PATCH 0/3] sched: Miscellaneous isolation related cleanups Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240818234520.90186-4-longman@redhat.com \
--to=longman@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox