From: David Hunter <david.hunter.linux@gmail.com>
To: mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
javier.carrasco.cruz@gmail.com, shuah@kernel.org,
david.hunter.linux@gmail.com
Subject: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup
Date: Mon, 19 Aug 2024 21:35:49 -0400 [thread overview]
Message-ID: <20240820013550.4906-1-david.hunter.linux@gmail.com> (raw)
Use the _free function to have automatic clean up instead of calling
another function, of_node_put. This prevents leaking reference counts.
The following commit has information on _free(device_node):
9448e55d032d99af8e23487f51a542d51b2f1a48
The code was able to compile without errors or warnings.
Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
drivers/clk/clk-qoriq.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 4dcde305944c..941a0372db4b 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -1065,11 +1065,8 @@ static void __init _clockgen_init(struct device_node *np, bool legacy);
static void __init legacy_init_clockgen(struct device_node *np)
{
if (!clockgen.node) {
- struct device_node *parent_np;
-
- parent_np = of_get_parent(np);
+ struct device_node __free(device_node) *parent_np = of_get_parent(np);
_clockgen_init(parent_np, true);
- of_node_put(parent_np);
}
}
--
2.43.0
next reply other threads:[~2024-08-20 1:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 1:35 David Hunter [this message]
2024-08-20 22:03 ` [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup Stephen Boyd
2024-08-21 1:07 ` [PATCH 1/1 V2] " David Hunter
2024-08-28 0:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820013550.4906-1-david.hunter.linux@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox