From: Christoph Hellwig <hch@lst.de>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: Trace dma_map/unmap_page
Date: Thu, 22 Aug 2024 06:20:17 +0200 [thread overview]
Message-ID: <20240822042017.GA889@lst.de> (raw)
In-Reply-To: <20240812204358.3587730-1-sean.anderson@linux.dev>
On Mon, Aug 12, 2024 at 04:43:57PM -0400, Sean Anderson wrote:
> When debugging drivers, it can often be useful to trace when memory gets
> (un)mapped for DMA (and can be accessed by the device). Add some
> tracepoints for this purpose. While there are many other interesting DMA
> functions, this is a useful start for simpler drivers.
Just dma_map/unmap_page seems a bit too limited and asymmetric. Can
you please also add tracing for ->map/unmap_sg and ->map/unmap_resoure
so that we at least cover all the dyanmic DMA mapping interfaces?
prev parent reply other threads:[~2024-08-22 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 20:43 [PATCH] dma: Trace dma_map/unmap_page Sean Anderson
2024-08-22 4:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822042017.GA889@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox