Re: [PATCH v5 03/10] regulator: Split up _regulator_get()

Andy Shevchenko
2024-08-22T13:49:34Z

On Thu, Aug 22, 2024 at 05:19:56PM +0800, Chen-Yu Tsai wrote:
> _regulator_get() contains a lot of common code doing checks prior to the
> regulator lookup and housekeeping work after the lookup. Almost all the
> code could be shared with a OF-specific variant of _regulator_get().
>
> Split out the common parts so that they can be reused. The OF-specific
> version of _regulator_get() will be added in a subsequent patch.
> No functional changes were made.

> +/**
> + * _regulator_get_common - Common code for regulator requests
> + * @rdev: regulator device pointer as returned by *regulator_dev_lookup()
> + * Its reference count is expected to have been incremented.
> + * @dev: device used for dev_printk messages
> + * @id: Supply name or regulator ID
> + * @get_type: enum regulator_get_type value corresponding to type of request
> + *
> + * Returns a struct regulator corresponding to @rdev,
> + * or IS_ERR() condition containing errno.
> + *
> + * This function should be chained with *regulator_dev_lookup() functions.

kernel-doc will warn here: No "Return" section.

> + */

--
With Best Regards,
Andy Shevchenko