* [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
@ 2024-08-21 7:17 Yang Ruibin
2024-08-22 9:05 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Yang Ruibin @ 2024-08-21 7:17 UTC (permalink / raw)
To: Tony Luck, Borislav Petkov, linux-edac, linux-kernel
Cc: opensource.kernel, Yang Ruibin
The debugfs_create_dir() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
drivers/ras/cec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index e440b15fbabc..ebd4631b685b 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
}
d = debugfs_create_dir("cec", dfs);
- if (!d) {
+ if (IS_ERR(d)) {
pr_warn("Error creating cec debugfs node!\n");
return -1;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
2024-08-21 7:17 [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for debugfs_create_dir() Yang Ruibin
@ 2024-08-22 9:05 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-08-22 9:05 UTC (permalink / raw)
To: Yang Ruibin
Cc: Tony Luck, Borislav Petkov, linux-edac, linux-kernel,
opensource.kernel
On Wed, 21 Aug 2024 03:17:18 -0400
Yang Ruibin <11162571@vivo.com> wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
>
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
Ideally needs a fixes tag.
Otherwise (given I looked into a similar one last night
with the same pattern).
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/ras/cec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index e440b15fbabc..ebd4631b685b 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
> }
>
> d = debugfs_create_dir("cec", dfs);
> - if (!d) {
> + if (IS_ERR(d)) {
> pr_warn("Error creating cec debugfs node!\n");
> return -1;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-22 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 7:17 [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for debugfs_create_dir() Yang Ruibin
2024-08-22 9:05 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox