From: Yazen Ghannam <yazen.ghannam@amd.com>
To: boris.ostrovsky@oracle.com
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com, x86@kernel.org, avadhut.naik@amd.com,
john.allen@amd.com
Subject: Re: [PATCH] x86/MCE: Prevent CPU offline for SMCA CPUs with non-core banks
Date: Thu, 22 Aug 2024 10:14:32 -0400 [thread overview]
Message-ID: <20240822141432.GA211090@yaz-khff2.amd.com> (raw)
In-Reply-To: <2eb4d710-fc8a-4210-a681-666a7ce1afe8@oracle.com>
On Wed, Aug 21, 2024 at 02:35:23PM -0400, boris.ostrovsky@oracle.com wrote:
>
>
> On 8/21/24 10:00 AM, Yazen Ghannam wrote:
>
> > + if (!mce_cpu_is_hotpluggable()) {
> > + pr_info("CPU%d is not hotpluggable\n", cpu);
>
> Can this error message be made a little more informative, e.g. that it is
> emitted from MCA code? And is info the right level? I think notice would be
> more appropriate.
>
Sure thing. I can change the level to notice.
The MCE subsystem has a global prefix set already by pr_fmt. This is
defined in arch/x86/kernel/cpu/mce/internal.h.
Thanks,
Yazen
next prev parent reply other threads:[~2024-08-22 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 14:00 [PATCH] x86/MCE: Prevent CPU offline for SMCA CPUs with non-core banks Yazen Ghannam
2024-08-21 18:35 ` boris.ostrovsky
2024-08-22 14:14 ` Yazen Ghannam [this message]
2024-08-25 11:16 ` Thomas Gleixner
2024-08-26 13:20 ` Yazen Ghannam
2024-08-27 12:50 ` Borislav Petkov
2024-08-27 13:47 ` Yazen Ghannam
2024-08-29 8:39 ` Borislav Petkov
2024-08-29 14:03 ` Yazen Ghannam
2024-08-29 14:14 ` Borislav Petkov
2024-08-29 14:18 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822141432.GA211090@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=avadhut.naik@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox