From: Jason Gunthorpe <jgg@ziepe.ca>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
andersson@kernel.org, afd@ti.com, nm@ti.com, hnagalla@ti.com,
b-padhi@ti.com, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
linux-remoteproc@vger.kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] remoteproc: Use iommu_paging_domain_alloc()
Date: Thu, 22 Aug 2024 13:24:25 -0300 [thread overview]
Message-ID: <20240822162425.GE3468552@ziepe.ca> (raw)
In-Reply-To: <ZsdktJEqR9BOgivK@p14s>
On Thu, Aug 22, 2024 at 10:17:56AM -0600, Mathieu Poirier wrote:
> > - domain = iommu_domain_alloc(dev->bus);
> > - if (!domain) {
> > + domain = iommu_paging_domain_alloc(dev);
>
> I'm a little hesitant here. Function iommu_domain_alloc() passes NULL two the
> second argument of __iommu_domain_alloc() while iommu_paging_domain_alloc()
> provides a 'dev'. I don't have any HW to test on and I am not familiar enough
> with the IOMMU subsystem to confidently more forward.
So long as dev is the device that will be initiating DMA this is a
correct change from the iommu subsystem perspective.
Jason
next prev parent reply other threads:[~2024-08-22 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 7:28 [PATCH 1/1] remoteproc: Use iommu_paging_domain_alloc() Lu Baolu
2024-08-22 16:17 ` Mathieu Poirier
2024-08-22 16:24 ` Jason Gunthorpe [this message]
2024-09-15 14:09 ` Jason Gunthorpe
2024-09-16 15:22 ` Mathieu Poirier
2024-08-29 6:17 ` Beleswar Prasad Padhi
2024-09-22 11:27 ` Beleswar Prasad Padhi
2024-09-23 18:12 ` Jason Gunthorpe
2024-09-30 16:40 ` Mathieu Poirier
2024-10-01 13:35 ` Jason Gunthorpe
2024-10-03 13:58 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822162425.GE3468552@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=b-padhi@ti.com \
--cc=baolu.lu@linux.intel.com \
--cc=hnagalla@ti.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox