Re: [PATCH v3] PCI: Detect and trust built-in Thunderbolt chips

Mika Westerberg
2024-08-23T05:01:24Z

Hi,

On Thu, Aug 22, 2024 at 10:56:44AM -0500, Mario Limonciello wrote:
> > > Here's the snippet from the kernel log with the patch in place. You can see
> > > it flagged 00:02.0 as untrusted and removable, but it definitely isn't.
> >
> > Is it marked as ExternalFacingPort in the ACPI tables?
>
> No; it doesn't have an ACPI companion device.

Hm, how can it pass this then?

static bool pcie_is_tunneled(struct pci_dev *pdev)
{
...
/* Internal PCIe devices are not tunneled. */
if (!root->external_facing)
return false;
...

Would you mind adding some debug statements there so we can see
(hopefully) what goes wrong?

The intention is that pcie_switch_directly_under() is only called on
Intel pre-USB4 discrete controllers (well and Maple Ridge as that's
still using the Connection Manager firmware).