Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range

Andy Shevchenko
2024-08-26T17:23:26Z

On Mon, Aug 26, 2024 at 03:23:50PM +0200, Petr Mladek wrote:
> On Thu 2024-08-22 21:10:25, Andy Shevchenko wrote:
> > On Thu, Aug 22, 2024 at 12:53:32PM -0500, Ira Weiny wrote:
> > > Petr Mladek wrote:
> > > > On Fri 2024-08-16 09:44:10, Ira Weiny wrote:

...

> > > > > + %par [range 0x60000000-0x6fffffff] or
> > > >
> > > > It seems that it is always 64-bit. It prints:
> > > >
> > > > struct range {
> > > > u64 start;
> > > > u64 end;
> > > > };
> > >
> > > Indeed. Thanks I should not have just copied/pasted.
> >
> > With that said, I'm not sure the %pa is a good placeholder for this ('a' stands
> > to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
>
> The r/R in %pr/%pR actually stands for "resource".
>
> But "%ra" really looks like a better choice than "%par". Both
> "resource" and "range" starts with 'r'. Also the struct resource
> is printed as a range of values.

Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.

> > > > > + [range 0x0000000060000000-0x000000006fffffff]
> > > > > +
> > > > > +For printing struct range. A variation of printing a physical address is to
> > > > > +print the value of struct range which are often used to hold a physical address
> > > > > +range.
> > > > > +
> > > > > +Passed by reference.

--
With Best Regards,
Andy Shevchenko