Re: [PATCH net-next] net: liquidio: Remove unused declarations

Simon Horman
2024-08-25T08:18:23Z

On Sat, Aug 24, 2024 at 04:31:07PM +0800, Yue Haibing wrote:
> Commit da15c78b5664 ("liquidio CN23XX: VF register access") declared
> cn23xx_dump_vf_initialized_regs() but never implemented it.
>
> octeon_dump_soft_command() is never implemented and used since introduction in
> commit 35878618c92d ("liquidio: Added delayed work for periodically updating
> the link statistics.").
>
> And finally, a few other declarations were never implenmented since introduction
> in commit f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters").
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks, I looked over the git history of this driver
and agree with the analysis above.

Reviewed-by: Simon Horman <horms@kernel.org>