* [PATCH] drm/etnaviv: Use unsigned type to count the number of pages
@ 2024-08-25 16:23 Sui Jingfeng
2024-08-26 14:22 ` Christian Gmeiner
0 siblings, 1 reply; 2+ messages in thread
From: Sui Jingfeng @ 2024-08-25 16:23 UTC (permalink / raw)
To: Lucas Stach, Russell King, Christian Gmeiner
Cc: David Airlie, Daniel Vetter, etnaviv, dri-devel, linux-kernel,
Sui Jingfeng
The drm_prime_pages_to_sg() function takes unsigned int argument to store
length of the page vector, and the type of struct drm_gem_object::size is
a size_t. The size of the object in CPU pages can not be negative, hence,
use unsigned variable to store the number of pages, instead of the signed
type.
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
index 3524b5811682..6b98200068e4 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
@@ -17,7 +17,7 @@ static struct lock_class_key etnaviv_prime_lock_class;
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
{
struct etnaviv_gem_object *etnaviv_obj = to_etnaviv_bo(obj);
- int npages = obj->size >> PAGE_SHIFT;
+ unsigned int npages = obj->size >> PAGE_SHIFT;
if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
return ERR_PTR(-EINVAL);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/etnaviv: Use unsigned type to count the number of pages
2024-08-25 16:23 [PATCH] drm/etnaviv: Use unsigned type to count the number of pages Sui Jingfeng
@ 2024-08-26 14:22 ` Christian Gmeiner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Gmeiner @ 2024-08-26 14:22 UTC (permalink / raw)
To: Sui Jingfeng
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter, etnaviv,
dri-devel, linux-kernel
>
> The drm_prime_pages_to_sg() function takes unsigned int argument to store
> length of the page vector, and the type of struct drm_gem_object::size is
> a size_t. The size of the object in CPU pages can not be negative, hence,
> use unsigned variable to store the number of pages, instead of the signed
> type.
>
> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 3524b5811682..6b98200068e4 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -17,7 +17,7 @@ static struct lock_class_key etnaviv_prime_lock_class;
> struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct etnaviv_gem_object *etnaviv_obj = to_etnaviv_bo(obj);
> - int npages = obj->size >> PAGE_SHIFT;
> + unsigned int npages = obj->size >> PAGE_SHIFT;
>
> if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-EINVAL);
> --
> 2.34.1
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-26 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-25 16:23 [PATCH] drm/etnaviv: Use unsigned type to count the number of pages Sui Jingfeng
2024-08-26 14:22 ` Christian Gmeiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox