* [PATCH] drm/etnaviv: Use unsigned type to count the number of userspace pages
@ 2024-08-25 17:41 Sui Jingfeng
2024-08-26 14:23 ` Christian Gmeiner
0 siblings, 1 reply; 2+ messages in thread
From: Sui Jingfeng @ 2024-08-25 17:41 UTC (permalink / raw)
To: Lucas Stach, Russell King, Christian Gmeiner
Cc: David Airlie, Daniel Vetter, etnaviv, dri-devel, linux-kernel,
Sui Jingfeng
The unpin_user_pages() function takes an unsigned long argument to store
length of the number of user space pages, and struct drm_gem_object::size
is a size_t type. The number of pages can not be negative, hence, use an
unsigned variable to store the number of pages.
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index ce9c9233c4a6..fa0d193cec26 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -695,7 +695,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)
kfree(etnaviv_obj->sgt);
}
if (etnaviv_obj->pages) {
- int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
+ unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
unpin_user_pages(etnaviv_obj->pages, npages);
kvfree(etnaviv_obj->pages);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/etnaviv: Use unsigned type to count the number of userspace pages
2024-08-25 17:41 [PATCH] drm/etnaviv: Use unsigned type to count the number of userspace pages Sui Jingfeng
@ 2024-08-26 14:23 ` Christian Gmeiner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Gmeiner @ 2024-08-26 14:23 UTC (permalink / raw)
To: Sui Jingfeng
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter, etnaviv,
dri-devel, linux-kernel
>
> The unpin_user_pages() function takes an unsigned long argument to store
> length of the number of user space pages, and struct drm_gem_object::size
> is a size_t type. The number of pages can not be negative, hence, use an
> unsigned variable to store the number of pages.
>
> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index ce9c9233c4a6..fa0d193cec26 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -695,7 +695,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)
> kfree(etnaviv_obj->sgt);
> }
> if (etnaviv_obj->pages) {
> - int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> + unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
>
> unpin_user_pages(etnaviv_obj->pages, npages);
> kvfree(etnaviv_obj->pages);
> --
> 2.34.1
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-26 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-25 17:41 [PATCH] drm/etnaviv: Use unsigned type to count the number of userspace pages Sui Jingfeng
2024-08-26 14:23 ` Christian Gmeiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox