* [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings
@ 2024-08-26 19:17 Rob Herring (Arm)
2024-08-31 10:47 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-08-26 19:17 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen; +Cc: linux-iio, linux-kernel
The vendorless compatible strings are deprecated and weren't retained
when the binding was converted to schema. As a result, they are listed
as undocumented when running "make dt_compatible_check". Rather than add
them back to the schema, let's just drop them as they are unnecessary.
Furthermore, they are unnecessary as the SPI matching will strip the
vendor prefix on compatible string and match that against the
spi_device_id table.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/iio/adc/mcp320x.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
index da1421bd7b62..57cff3772ebe 100644
--- a/drivers/iio/adc/mcp320x.c
+++ b/drivers/iio/adc/mcp320x.c
@@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi)
}
static const struct of_device_id mcp320x_dt_ids[] = {
- /* NOTE: The use of compatibles with no vendor prefix is deprecated. */
- { .compatible = "mcp3001" },
- { .compatible = "mcp3002" },
- { .compatible = "mcp3004" },
- { .compatible = "mcp3008" },
- { .compatible = "mcp3201" },
- { .compatible = "mcp3202" },
- { .compatible = "mcp3204" },
- { .compatible = "mcp3208" },
- { .compatible = "mcp3301" },
{ .compatible = "microchip,mcp3001" },
{ .compatible = "microchip,mcp3002" },
{ .compatible = "microchip,mcp3004" },
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings
2024-08-26 19:17 [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings Rob Herring (Arm)
@ 2024-08-31 10:47 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-08-31 10:47 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: Lars-Peter Clausen, linux-iio, linux-kernel
On Mon, 26 Aug 2024 14:17:28 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:
> The vendorless compatible strings are deprecated and weren't retained
> when the binding was converted to schema. As a result, they are listed
> as undocumented when running "make dt_compatible_check". Rather than add
> them back to the schema, let's just drop them as they are unnecessary.
> Furthermore, they are unnecessary as the SPI matching will strip the
> vendor prefix on compatible string and match that against the
> spi_device_id table.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied.
Thanks,
> ---
> drivers/iio/adc/mcp320x.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index da1421bd7b62..57cff3772ebe 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi)
> }
>
> static const struct of_device_id mcp320x_dt_ids[] = {
> - /* NOTE: The use of compatibles with no vendor prefix is deprecated. */
> - { .compatible = "mcp3001" },
> - { .compatible = "mcp3002" },
> - { .compatible = "mcp3004" },
> - { .compatible = "mcp3008" },
> - { .compatible = "mcp3201" },
> - { .compatible = "mcp3202" },
> - { .compatible = "mcp3204" },
> - { .compatible = "mcp3208" },
> - { .compatible = "mcp3301" },
> { .compatible = "microchip,mcp3001" },
> { .compatible = "microchip,mcp3002" },
> { .compatible = "microchip,mcp3004" },
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-31 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 19:17 [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings Rob Herring (Arm)
2024-08-31 10:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox